Uploaded image for project: 'Shiro'
  1. Shiro
  2. SHIRO-564

WildcardPermission case-insensitive makes parts collections twice

Agile BoardAttach filesAttach ScreenshotVotersStop watchingWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.2.4
    • Fix Version/s: 1.3.0
    • Labels:
      None
    • Environment:
      Any

      Description

      WildcardPermissions have a caseSensitive flag that instructs the permission to ignore case when comparing permissions. It's implementation of this feature is kinda wasteful because it first parses the permission string into a Set<String> part, THEN checks the flag and then rebuilds the part Set.

      It might be faster to check the flag first, lowercase the permission string, then parse the parts. This would save creating a whole bunch of extra LinkedHashSets.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              mattbishop Matt Bishop

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment