Uploaded image for project: 'Shiro'
  1. Shiro
  2. SHIRO-564

WildcardPermission case-insensitive makes parts collections twice

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Trivial
    • Resolution: Fixed
    • 1.2.4
    • 1.3.0
    • None
    • Any

    Description

      WildcardPermissions have a caseSensitive flag that instructs the permission to ignore case when comparing permissions. It's implementation of this feature is kinda wasteful because it first parses the permission string into a Set<String> part, THEN checks the flag and then rebuilds the part Set.

      It might be faster to check the flag first, lowercase the permission string, then parse the parts. This would save creating a whole bunch of extra LinkedHashSets.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              mattbishop Matt Bishop
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: