[SHIRO-562] WildcardPermission calls String.trim() twice in setParts()

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.2.4
• Fix Version/s: 1.2.5
• Component/s: Authorization (access control)
• Environment: any
• Assignee: Unassigned
• Reporter: Matt Bishop
• Created: 17/Mar/16 23:12
• Updated: 08/Nov/16 16:45
• Resolved: 21/Mar/16 18:45

Description

WildcardPermission.setParts does this:

if (wildcardString == null || wildcardString.trim().length() == 0)

Unknown macro: { throw new IllegalArgumentException("Wildcard string cannot be null or empty. Make sure permission strings are properly formatted."); }

wildcardString = wildcardString.trim();

Given the frequency of the use of this method it would be better to capture the first trim().