[SHIRO-480] setTarget method in DomainPermission does not set targets

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.2.2
• Fix Version/s: 1.3.0
• Component/s: Authorization (access control)
• Assignee: Unassigned
• Reporter: William Weiss
• Created: 17/Jan/14 03:00
• Updated: 06/Jul/16 18:57
• Resolved: 06/Jul/16 18:57

Description

The setTarget() method in org.apache.shiro.authz.permission.DomainPermission has an apparent typo, or copy paste error:

133 protected void setTargets(Set<String> targets) {
134 this.targets = targets;
135 if (this.targets != null && this.targets.equals(targets))

{ 136 return; 137 }

138 this.targets = targets;
139 setParts(domain, actions, targets);
140 }

As you can see, line 134 is a duplicate of line 138 and will in all cases, except where the argument targets is null, prevent execution from ever calling setParts() and functioning properly.

The work around for now is for classes extending DomainPermission to handle the call to setParts() directly.

Issue Links

• links to: GitHub Pull Request #22