[SHIRO-473] DefaultAnnotationResolver.getAnnotation throws NullPointerException

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.2
• Fix Version/s: 1.3.0
• Component/s: Integration: JEE
• Labels: AOP AnnotationResolver NullPointerException patch
• Environment: Cross platform / Play Framework 2.2
• Assignee: Unassigned
• Reporter: Sergiy Sokolenko
• Created: 26/Nov/13 16:40
• Updated: 01/Jul/16 18:02
• Resolved: 01/Jul/16 18:02

Description

Bug Description

The method org.apache.shiro.aop.DefaultAnnotationResolver.getAnnotation throws NullPointerException when a given MethodInvocation argument represents static method:

Technical Info

http://shiro.apache.org/static/1.2.2/apidocs/src-html/org/apache/shiro/aop/DefaultAnnotationResolver.html#line.62:

return annotation == null ? mi.getThis().getClass().getAnnotation(clazz) : annotation;

if annotation is null and mi represents static method invocation, then mi.getThis() will return null causing the following chained call getClass() fail with NullPointerException.

Resolution

See attached patch: DefaultAnnotationResolver.java.diff.