Uploaded image for project: 'Shiro'
  1. Shiro
  2. SHIRO-452

SimpleSession serialization failing

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 1.2.1
    • Fix Version/s: None
    • Labels:
      None
    • Environment:
      Java 6 - EhCache 2.6.2

      Description

      We cache SimpleSession in EhCache which is configured with Overflow to Disk and an LRU eviction policy.

      When the cache is full, EhCache will attempt to evict a session from the Disk Storage to reclaim space.
      To evict the `SimpleSession`, EhCache will attempt to deserialize the eveicted session first. From time to time, the deserialization of the `SimpleSession` fails. When that happens the system is locked, since no additional session can be created.

      `SimpleSession` has a custom serialization mechanism that calculates a bit mask which indicates which fields of the `SimpleSession` contain values. This bitMask is serialized first (as a Short) then the fields containing values.
      When deserialization is failing, the bitMask indicates that the `attributes` Map contains data, however no `attributes` have actually been serialized and the deserialization fails with a `java.io.OptionalDataException`.

      The discrepancy is very likely due to `attributes` being a non synchronized Map: the SimpleSession is created on a Servlet thread, however the serialization to Disk is performed by EhCache on one of its cache management threads.

      SimpleSession fields should likely be marked as volatile and the Map should be a Synchronized Map or SimpleSession should be made immutable.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              bgrieder Bruno GRIEDER
            • Votes:
              3 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated: