Shiro
  1. Shiro
  2. SHIRO-300

WildcardPermission: change visibility of field 'parts' to protected

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 1.1.0
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Change visibility of field 'parts' to protected, so Permissions extends WildcardPermission can directly fill parts instead of creating a String and calling setParts (which splits this string again into parts...)

        Issue Links

          Activity

          Hide
          Matt Bishop added a comment -

          Or better yet add a parts constructor.

          Show
          Matt Bishop added a comment - Or better yet add a parts constructor.
          Hide
          Matt Bishop added a comment -

          Instead of making parts protected, better to add protected setParts(List<Set<String> parts) to WildcardPermission.

          Show
          Matt Bishop added a comment - Instead of making parts protected, better to add protected setParts(List<Set<String> parts) to WildcardPermission.
          Hide
          ASF GitHub Bot added a comment -

          GitHub user mattbishop opened a pull request:

          https://github.com/apache/shiro/pull/17

          SHIRO-300 Add protected setParts(list) method

          WildcardPermission subclasses can create their own parts/subparts list and pass them in with this method.

          See https://issues.apache.org/jira/browse/SHIRO-300

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/mattbishop/shiro SHIRO-300

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/shiro/pull/17.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #17


          commit e2934d35be987c228a76575c1305341086a2c7bf
          Author: Matt Bishop <matthew.bishop@elasticpath.com>
          Date: 2016-05-29T19:06:01Z

          SHIRO-300 Add protected setParts(list) method to WildcardPermission so subclasses can create their own parts/subparts list.


          Show
          ASF GitHub Bot added a comment - GitHub user mattbishop opened a pull request: https://github.com/apache/shiro/pull/17 SHIRO-300 Add protected setParts(list) method WildcardPermission subclasses can create their own parts/subparts list and pass them in with this method. See https://issues.apache.org/jira/browse/SHIRO-300 You can merge this pull request into a Git repository by running: $ git pull https://github.com/mattbishop/shiro SHIRO-300 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/shiro/pull/17.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #17 commit e2934d35be987c228a76575c1305341086a2c7bf Author: Matt Bishop <matthew.bishop@elasticpath.com> Date: 2016-05-29T19:06:01Z SHIRO-300 Add protected setParts(list) method to WildcardPermission so subclasses can create their own parts/subparts list.

            People

            • Assignee:
              Unassigned
              Reporter:
              manthos
            • Votes:
              3 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:

                Development