Uploaded image for project: 'Shiro'
  1. Shiro
  2. SHIRO-179

Invalid expires date format with non english default locale

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Duplicate
    • Affects Version/s: None
    • Fix Version/s: 1.1.0
    • Component/s: Web
    • Labels:
      None
    • Environment:
      I'm on a french locale java system

      Description

      There is a problem with the "rememberMe" cookie feature.

      A cookie is sent to the user to store the rememberMe data, but the expiration date used for the formating is the system default one.
      In my case, expiration date are formated in french and the browser cannot correctly handle it (so rememberMe cookie will automatically be removed when the browser is closed)

      A fix could be done in the class : org.apache.shiro.web.servlet.SimpleCookie

      Around line 330 :

      private static String toCookieDate(Date date)

      { TimeZone tz = TimeZone.getTimeZone(GMT_TIME_ZONE_ID); DateFormat fmt = new SimpleDateFormat(COOKIE_DATE_FORMAT_STRING); // Here, SimpleDateFormat use default Locale fmt.setTimeZone(tz); return fmt.format(date); }

      replace with :

      private static String toCookieDate(Date date)

      { TimeZone tz = TimeZone.getTimeZone(GMT_TIME_ZONE_ID); DateFormat fmt = new SimpleDateFormat(COOKIE_DATE_FORMAT_STRING, Locale.ENGLISH); // Force english locale fmt.setTimeZone(tz); return fmt.format(date); }

      A workaround is to replace the default local when calling the login() method :

      Locale systemLocale = Locale.getDefault();
      Locale.setDefault(Locale.ENGLISH);
      currentUser.login(token);
      Locale.setDefault(systemLocale);

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                kaosko Kalle Korhonen
                Reporter:
                nicolas.antoniazzi Nicolas ANTONIAZZI
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: