Shindig
  1. Shindig
  2. SHINDIG-705

Allow extending with new services without having to change ApiServlet code

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0
    • Component/s: PHP
    • Labels:
      None

      Description

      Currently one is required to change the ApiServlet code to be able the extend Shindig with new services. This patch makes the extending of Shindig with new services configurable.

      1. main_patch.txt
        14 kB
        Erik Gomersbach
      2. output_converter_tests_patch.txt
        14 kB
        Erik Gomersbach
      3. output_converter_patch.txt
        36 kB
        Erik Gomersbach
      4. input_converter_tests_patch.txt
        31 kB
        Erik Gomersbach
      5. input_converter_patch.txt
        15 kB
        Erik Gomersbach
      6. configuration_patch.txt
        2 kB
        Erik Gomersbach

        Activity

        Hide
        Erik Gomersbach added a comment -

        Updated version of first patch.

        Show
        Erik Gomersbach added a comment - Updated version of first patch.
        Hide
        Chris Chabot added a comment -

        Hey Erik,

        First of all thanks for working on this!

        While trying to look through the patch, I couldn't help but noticing it --'s and ++'s a lot more then I would expect, a total of a 130k of changes is slightly more then expected ) (It would seem a lot of it is just code formatting stuff)

        To be able to actually see what this does (and not make the project's code formatting inconsistent) I would really love to have a bit more concise patch that only consists of the actual changes

        Show
        Chris Chabot added a comment - Hey Erik, First of all thanks for working on this! While trying to look through the patch, I couldn't help but noticing it --'s and ++'s a lot more then I would expect, a total of a 130k of changes is slightly more then expected ) (It would seem a lot of it is just code formatting stuff) To be able to actually see what this does (and not make the project's code formatting inconsistent) I would really love to have a bit more concise patch that only consists of the actual changes
        Hide
        Chris Chabot added a comment -

        Hey Erik,

        Patch looks good to me, but I'm holding off for a few days more until we can be sure the release branch and trunk are synced properly for release; The impact of this patch is slightly to large to sneak it into the 1.0.0 release at the very last moment.

        Will apply it soon, and thanks for the great work on this!

        Show
        Chris Chabot added a comment - Hey Erik, Patch looks good to me, but I'm holding off for a few days more until we can be sure the release branch and trunk are synced properly for release; The impact of this patch is slightly to large to sneak it into the 1.0.0 release at the very last moment. Will apply it soon, and thanks for the great work on this!
        Hide
        Erik Gomersbach added a comment -

        Updated to New Revision: 735420 of DataServiceServlet

        Show
        Erik Gomersbach added a comment - Updated to New Revision: 735420 of DataServiceServlet
        Hide
        Bastian Hofmann added a comment -

        patch committed

        Show
        Bastian Hofmann added a comment - patch committed

          People

          • Assignee:
            Unassigned
            Reporter:
            Erik Gomersbach
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development