Uploaded image for project: 'Shindig'
  1. Shindig
  2. SHINDIG-647

Adding gadgets.views.View#checkType() function

    XMLWordPrintableJSON

Details

    • New Feature
    • Status: Resolved
    • Major
    • Resolution: Invalid
    • None
    • None
    • Javascript
    • None

    Description

      I have propose to add gadgets.views.View#checkType() function. This proposal is written in following entry:

      http://groups.google.com/group/opensocial-and-gadgets-spec/browse_thread/thread/e4896bbdf6e5626


      In some containers based on apache shindig, the result of the
      gadgets.views.View#getName() function is not equal to the constant
      value defined by gadgets.views.ViewType class. In particular, the
      result of the gadgets.views.View#getName() on the canvas view is
      "canvas" written in the config/container.js file, and the constant
      value of ViewType.CANVAS is defined as "CANVAS" in the features/views/
      views.js file.

      Therefore, in current version of opensocial, we cannot confirm which
      view type is this view using getName() function. But, fortunately, it
      will be able to ensure that "CANVAS" and "canvas" is same, because
      each view can have some aliases.

      My proposal is to add the following function for checking view type.

      I made this implementation. Please commit this patch if this proposal is accepted.

      Attachments

        1. add-checkType-method.patch
          2 kB
          Yoichiro Tanaka

        Activity

          People

            Unassigned Unassigned
            yoichiro Yoichiro Tanaka
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: