[SHINDIG-1989] RENDER_DEBUG is set incorrectly in the sample container (documentation wrong too)

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 2.5.2
• Component/s: Javascript
• Assignee: Unassigned
• Reporter: Doug Davies
• Created: 05/Dec/14 14:43
• Updated: 05/Dec/14 14:55

Description

In common container if I set renderDebug as follows

testConfig[osapi.container.ContainerConfig.RENDER_DEBUG] = '0';

and then in container.js it does this

this.renderDebug_ = (typeof param === 'undefined') ?
Boolean(osapi.container.util.getSafeJsonValue(config,
osapi.container.ContainerConfig.RENDER_DEBUG, false)) :
(param === '1');

which sets this.renderDebug_ to TRUE (incorrectly). I think the creation of the Boolean is only caring that the string has a value and setting to TRUE.

Is this a container/documentation error and we should fix the containers OR should the container.js code be able to handle the string? Having renderDebug set to always true means that caching of requests will never be turned on.