[SHINDIG-1968] Create CollectionOptions via a ~Factory instead of explicitly constructing them

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.5.0-update1
• Fix Version/s: 2.5.1
• Component/s: Java
• Assignee: Andreas Kohn
• Reporter: Andreas Kohn
• Created: 24/Feb/14 19:54
• Updated: 25/Feb/14 14:40
• Resolved: 25/Feb/14 14:40

Description

CollectionOptions instances are explicitly constructed via "new". For integrations CollectionOptions is also the ideal place to add additional parameter handling, without having to copy/paste the *Handler/*Service code.

In our specific case we are working with a different approach to filtering and searching that depends on additional parameters, as the existing ones from OpenSocial are simply not sufficient.

The patch in the review introduces a CollectionOptionsFactory with the obvious implementation, and changes the handlers to get that factory injected. In our integration we bind() the factory to our specific implementation that handles our parameters.

Issue was briefly discussed at http://mail-archives.apache.org/mod_mbox/shindig-dev/201402.mbox/%3CCAApR0qr8-pyko_CH9AvOhvsUZ_12L_b2rtAB-O6tb6JUtRyX8Q%40mail.gmail.com%3E