[SHINDIG-1965] iframe onload events firing more than once cause gadget iframe to empty

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.5.0-update1
• Fix Version/s: 2.5.1
• Assignee: Stanton Sievers
• Reporter: Stanton Sievers
• Created: 23/Jan/14 18:34
• Updated: 19/Feb/14 13:08
• Resolved: 19/Feb/14 13:08

Description

In the case a gadget iframe is re-parented, the iframe's onload handler will fire again. This causes osapi.container.GadgetSite.prototype.onRender to call remove() on currentGadgetHolder_ because it is not null.

This is easily reproducible in Apache Rave since it upgraded to Shindig 2.5.0-update1. Simply drag-and-drop a gadget on the page and its contents will disappear.

I think GadgetSite.onRender should either guard against this scenario by checking to see if loadingGadgetHolder_ is set before clearing out currentGadgetHolder_ or we should remove the onload handler entirely from the iframe once it has fired once.

Issue Links

• is related to: RAVE-1087 Dragging and dropping an OpenSocial gadget causes its iframe contents to disappear