[SHINDIG-1904] set response cache control to -1 for JsServlet when response code is 304

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.5.0-beta5
• Fix Version/s: 2.5.0-beta6
• Component/s: Java
• Assignee: Stanton Sievers
• Reporter: Marshall Shi
• Created: 19/Feb/13 05:56
• Updated: 25/Feb/13 12:38
• Resolved: 25/Feb/13 12:37

Description

We've encountered problems that a proxy sitting in front of a Shindig server is reading the cache control to determine whether or not to cache the content in the proxy. It is problematic because the cache control max age defaults to 0 in case of 304 response code in JsServlet.
We expect the cache control indicate that the response should be cached in browser indefinitely.
The proposed fix is to set -1 as cacheTtl in the JsResponseBuilder and pass that cacheTtl value back into the JsServlet response header.