[SHINDIG-1867] AllJsIFrameVersioner causes large memory allocation

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.5.0-beta4
• Fix Version/s: 2.5.0, 2.5.0-beta5
• Component/s: Java
• Assignee: Unassigned
• Reporter: Marshall Shi
• Created: 12/Sep/12 13:57
• Updated: 19/Sep/12 23:46
• Resolved: 19/Sep/12 16:35

Description

The AllJsIframeVersioner causes a massive memory allocation executing the following:

StringBuilder jsBuf = new StringBuilder();
for (FeatureResource resource : registry.getAllFeatures().getResources())

{ jsBuf.append(resource.getContent()).append(resource.getDebugContent()); }

this.allJsChecksum = HashUtil.checksum(jsBuf.toString().getBytes());

The two problems with this are:
(1) Creates a massive char[] for that string (we tested with a 4M resource)
(2) Then allocates a new byte[] for that giant string

Proposed solution is to just use a simple message digest object against each resource content. And concat all the bytes for HashUtil.checksum.