Uploaded image for project: 'Shindig'
  1. Shindig
  2. SHINDIG-1864

Change oauthpopup feature to do window.open call from the container page

Details

    • Improvement
    • Status: Reopened
    • Major
    • Resolution: Unresolved
    • None
    • None
    • Java, Javascript
    • None

    Description

      The container will now handle the launching of oauth requests and fire onopen and onclose events back into the requesting gadgets. This will allow container implementations to override the default behavior and possibly surface them in liteboxes rather than relying on window.open which is often prevented by popup blockers.

      This also paves the way for enhancements such as doing an oauth dance before a gadget even renders for pipelined data that is oauth protected.

      ---------------------------
      All oauthpopup changes made up until they were reverted are in the attached patch. There still exists a problem when this patch is applied where gadgets on a locked domain cannot complete the oauth dance.
      This problem is discussed in this review: https://reviews.apache.org/r/7186/

      Attachments

        Activity

          People

            ddumont Dan Dumont
            ddumont Dan Dumont
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: