[SHINDIG-1838] RenderingGadgetRewriterTest.xhrWrapperConfigurationInjected fails in Java 5 builds

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.5.0-beta3
• Fix Version/s: 2.5.0-beta4
• Component/s: Java
• Labels: junit test
• Environment: builds.apache.org ubuntu executors. Java 5.
• Assignee: Stanton Sievers
• Reporter: Stanton Sievers
• Created: 07/Aug/12 11:05
• Updated: 12/Aug/12 19:52
• Resolved: 12/Aug/12 19:52

Description

One test case is failing when building Shindig against Java 5. The issue seems to simply be a poor equality check of JSON objects. The attributes are in a different order in the Java 5 results, causing the compare to fail.

org.apache.shindig.gadgets.render.RenderingGadgetRewriterTest.xhrWrapperConfigurationInjected

Error Message

No shindig.xhrwrapper.oauthTokenName configuration present in rewritten HTML. expected:<...bar/baz.html","oauth[Service":"serviceName","oauthTokenName":"token]Name"}> but was:<...bar/baz.html","oauth[TokenName":"tokenName","oauthService":"service]Name"}>

Stacktrace

org.junit.ComparisonFailure: No shindig.xhrwrapper.oauthTokenName configuration present in rewritten HTML. expected:<...bar/baz.html","oauth[Service":"serviceName","oauthTokenName":"token]Name"}> but was:<...bar/baz.html","oauth[TokenName":"tokenName","oauthService":"service]Name"}>
at org.junit.Assert.assertEquals(Assert.java:125)
at org.apache.shindig.gadgets.render.RenderingGadgetRewriterTest.assertXhrConfigContains(RenderingGadgetRewriterTest.java:933)
at org.apache.shindig.gadgets.render.RenderingGadgetRewriterTest.checkXhrWrapperConfigurationInjection(RenderingGadgetRewriterTest.java:918)
at org.apache.shindig.gadgets.render.RenderingGadgetRewriterTest.xhrWrapperConfigurationInjected(RenderingGadgetRewriterTest.java:872)