Details

      Description

      To reproduce:
      1) Create a gadget that requires both open-views and pubsub-2 features.
      2) Make a call to gadgets.views.openGadget(), passing a viewParams object
      3) In the newly opened gadget, make a call to gadgets.views.getParams(). You will receive an empty object, regardless of what was passed as a parameter.

      What's happening?
      1) It looks like pubsub-2 appends an rpc token to the open gadget url in the form of #rpctoken=nzZsoU
      2) The resulting url param for views looks like this - view-params: "

      {"value":"yarrrgh","retVal":""}

      #rpctoken=nzZsoU"
      2) In the views feature, views.js, line 120: The param goes through json.parse, which fails and returns an empty object

      This will probably affect more than just the openviews feature.

      1. 1777.patch
        5 kB
        Erin Noe-Payne

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5113/
        -----------------------------------------------------------

        (Updated 2012-05-15 12:42:36.481625)

        Review request for shindig.

        Changes
        -------

        fixed bug link

        Summary
        -------

        pubsub-2 appends an rpc token with a hashtag to the open gadget url. When the url parameters are split by '&', hash tags are skipped and json.parse fails on the resulting parameter.

        Switched to global replace to avoid the issue.

        This addresses bug SHINDIG-1777.
        https://issues.apache.org/jira/browse/SHINDIG-1777

        Diffs


        trunk/features/src/main/javascript/features/core.util.urlparams/urlparams.js 1338216

        Diff: https://reviews.apache.org/r/5113/diff

        Testing
        -------

        Chrome, FF 12, IE 8/9

        Thanks,

        Erin

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5113/ ----------------------------------------------------------- (Updated 2012-05-15 12:42:36.481625) Review request for shindig. Changes ------- fixed bug link Summary ------- pubsub-2 appends an rpc token with a hashtag to the open gadget url. When the url parameters are split by '&', hash tags are skipped and json.parse fails on the resulting parameter. Switched to global replace to avoid the issue. This addresses bug SHINDIG-1777 . https://issues.apache.org/jira/browse/SHINDIG-1777 Diffs trunk/features/src/main/javascript/features/core.util.urlparams/urlparams.js 1338216 Diff: https://reviews.apache.org/r/5113/diff Testing ------- Chrome, FF 12, IE 8/9 Thanks, Erin
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-05-15 12:28:16, Stanton Sievers wrote:

        > I'm not seeing how the existing code is causing the issue. Do you have a sample input url to parseUrlParams that causes the issue?

        See an example url below. There are two hash tags in this url, the first being right after &mid=0. The original code will catch only one instance.

        http://localhost:8080/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fdemogadgets%2Fopen_views_demo.xml&container=default&view=popup&lang=%25lang%25&country=%25country%25&debug=1&nocache=1&sanitize=%25sanitize%25&v=d3083135601a3923d70da1a99b86fc65&st=default%3A-qZ05EIwCF5iJg0uia2gDYagSbzknSSqLsOGSZIDr6w3oVfg6ZHNQ0zD384lF5jO9tsyCsVocN9u9awbccSMC1onXMJv4BHgVIRIvLYGk0w5RWoJWhkskuW-0FlrMtXra3PTNNjjOfXnlUoQjX4Co6S1iC3B1fAleDlxVhiMokUsk_J7&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0#&view-params=%7B%22value%22%3A%22yarrrgh%22%2C%22retVal%22%3A%22%22%7D#rpctoken=jRo0mz&oahParent=http%3A%2F%2Flocalhost%3A8080

        • Erin

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5113/#review7889
        -----------------------------------------------------------

        On 2012-05-15 12:42:36, Erin Noe-Payne wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/5113/

        -----------------------------------------------------------

        (Updated 2012-05-15 12:42:36)

        Review request for shindig.

        Summary

        -------

        pubsub-2 appends an rpc token with a hashtag to the open gadget url. When the url parameters are split by '&', hash tags are skipped and json.parse fails on the resulting parameter.

        Switched to global replace to avoid the issue.

        This addresses bug SHINDIG-1777.

        https://issues.apache.org/jira/browse/SHINDIG-1777

        Diffs

        -----

        trunk/features/src/main/javascript/features/core.util.urlparams/urlparams.js 1338216

        Diff: https://reviews.apache.org/r/5113/diff

        Testing

        -------

        Chrome, FF 12, IE 8/9

        Thanks,

        Erin

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-05-15 12:28:16, Stanton Sievers wrote: > I'm not seeing how the existing code is causing the issue. Do you have a sample input url to parseUrlParams that causes the issue? See an example url below. There are two hash tags in this url, the first being right after &mid=0. The original code will catch only one instance. http://localhost:8080/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fdemogadgets%2Fopen_views_demo.xml&container=default&view=popup&lang=%25lang%25&country=%25country%25&debug=1&nocache=1&sanitize=%25sanitize%25&v=d3083135601a3923d70da1a99b86fc65&st=default%3A-qZ05EIwCF5iJg0uia2gDYagSbzknSSqLsOGSZIDr6w3oVfg6ZHNQ0zD384lF5jO9tsyCsVocN9u9awbccSMC1onXMJv4BHgVIRIvLYGk0w5RWoJWhkskuW-0FlrMtXra3PTNNjjOfXnlUoQjX4Co6S1iC3B1fAleDlxVhiMokUsk_J7&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0#&view-params=%7B%22value%22%3A%22yarrrgh%22%2C%22retVal%22%3A%22%22%7D#rpctoken=jRo0mz&oahParent=http%3A%2F%2Flocalhost%3A8080 Erin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5113/#review7889 ----------------------------------------------------------- On 2012-05-15 12:42:36, Erin Noe-Payne wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5113/ ----------------------------------------------------------- (Updated 2012-05-15 12:42:36) Review request for shindig. Summary ------- pubsub-2 appends an rpc token with a hashtag to the open gadget url. When the url parameters are split by '&', hash tags are skipped and json.parse fails on the resulting parameter. Switched to global replace to avoid the issue. This addresses bug SHINDIG-1777 . https://issues.apache.org/jira/browse/SHINDIG-1777 Diffs ----- trunk/features/src/main/javascript/features/core.util.urlparams/urlparams.js 1338216 Diff: https://reviews.apache.org/r/5113/diff Testing ------- Chrome, FF 12, IE 8/9 Thanks, Erin
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-05-15 12:28:16, Stanton Sievers wrote:

        > I'm not seeing how the existing code is causing the issue. Do you have a sample input url to parseUrlParams that causes the issue?

        Erin Noe-Payne wrote:

        See an example url below. There are two hash tags in this url, the first being right after &mid=0. The original code will catch only one instance.

        http://localhost:8080/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fdemogadgets%2Fopen_views_demo.xml&container=default&view=popup&lang=%25lang%25&country=%25country%25&debug=1&nocache=1&sanitize=%25sanitize%25&v=d3083135601a3923d70da1a99b86fc65&st=default%3A-qZ05EIwCF5iJg0uia2gDYagSbzknSSqLsOGSZIDr6w3oVfg6ZHNQ0zD384lF5jO9tsyCsVocN9u9awbccSMC1onXMJv4BHgVIRIvLYGk0w5RWoJWhkskuW-0FlrMtXra3PTNNjjOfXnlUoQjX4Co6S1iC3B1fAleDlxVhiMokUsk_J7&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0#&view-params=%7B%22value%22%3A%22yarrrgh%22%2C%22retVal%22%3A%22%22%7D#rpctoken=jRo0mz&oahParent=http%3A%2F%2Flocalhost%3A8080

        That URL is not valid. There can't be two "#" in a URL. It's also weird that the first "#" is followed by "&view-params", almost like the view params are simple being string concatenated. That's the real issue here. Where are you rendering this gadget?

        • Stanton

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5113/#review7889
        -----------------------------------------------------------

        On 2012-05-15 12:42:36, Erin Noe-Payne wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/5113/

        -----------------------------------------------------------

        (Updated 2012-05-15 12:42:36)

        Review request for shindig.

        Summary

        -------

        pubsub-2 appends an rpc token with a hashtag to the open gadget url. When the url parameters are split by '&', hash tags are skipped and json.parse fails on the resulting parameter.

        Switched to global replace to avoid the issue.

        This addresses bug SHINDIG-1777.

        https://issues.apache.org/jira/browse/SHINDIG-1777

        Diffs

        -----

        trunk/features/src/main/javascript/features/core.util.urlparams/urlparams.js 1338216

        Diff: https://reviews.apache.org/r/5113/diff

        Testing

        -------

        Chrome, FF 12, IE 8/9

        Thanks,

        Erin

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-05-15 12:28:16, Stanton Sievers wrote: > I'm not seeing how the existing code is causing the issue. Do you have a sample input url to parseUrlParams that causes the issue? Erin Noe-Payne wrote: See an example url below. There are two hash tags in this url, the first being right after &mid=0. The original code will catch only one instance. http://localhost:8080/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fdemogadgets%2Fopen_views_demo.xml&container=default&view=popup&lang=%25lang%25&country=%25country%25&debug=1&nocache=1&sanitize=%25sanitize%25&v=d3083135601a3923d70da1a99b86fc65&st=default%3A-qZ05EIwCF5iJg0uia2gDYagSbzknSSqLsOGSZIDr6w3oVfg6ZHNQ0zD384lF5jO9tsyCsVocN9u9awbccSMC1onXMJv4BHgVIRIvLYGk0w5RWoJWhkskuW-0FlrMtXra3PTNNjjOfXnlUoQjX4Co6S1iC3B1fAleDlxVhiMokUsk_J7&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0#&view-params=%7B%22value%22%3A%22yarrrgh%22%2C%22retVal%22%3A%22%22%7D#rpctoken=jRo0mz&oahParent=http%3A%2F%2Flocalhost%3A8080 That URL is not valid. There can't be two "#" in a URL. It's also weird that the first "#" is followed by "&view-params", almost like the view params are simple being string concatenated. That's the real issue here. Where are you rendering this gadget? Stanton ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5113/#review7889 ----------------------------------------------------------- On 2012-05-15 12:42:36, Erin Noe-Payne wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5113/ ----------------------------------------------------------- (Updated 2012-05-15 12:42:36) Review request for shindig. Summary ------- pubsub-2 appends an rpc token with a hashtag to the open gadget url. When the url parameters are split by '&', hash tags are skipped and json.parse fails on the resulting parameter. Switched to global replace to avoid the issue. This addresses bug SHINDIG-1777 . https://issues.apache.org/jira/browse/SHINDIG-1777 Diffs ----- trunk/features/src/main/javascript/features/core.util.urlparams/urlparams.js 1338216 Diff: https://reviews.apache.org/r/5113/diff Testing ------- Chrome, FF 12, IE 8/9 Thanks, Erin
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-05-15 12:28:16, Stanton Sievers wrote:

        > I'm not seeing how the existing code is causing the issue. Do you have a sample input url to parseUrlParams that causes the issue?

        Erin Noe-Payne wrote:

        See an example url below. There are two hash tags in this url, the first being right after &mid=0. The original code will catch only one instance.

        http://localhost:8080/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fdemogadgets%2Fopen_views_demo.xml&container=default&view=popup&lang=%25lang%25&country=%25country%25&debug=1&nocache=1&sanitize=%25sanitize%25&v=d3083135601a3923d70da1a99b86fc65&st=default%3A-qZ05EIwCF5iJg0uia2gDYagSbzknSSqLsOGSZIDr6w3oVfg6ZHNQ0zD384lF5jO9tsyCsVocN9u9awbccSMC1onXMJv4BHgVIRIvLYGk0w5RWoJWhkskuW-0FlrMtXra3PTNNjjOfXnlUoQjX4Co6S1iC3B1fAleDlxVhiMokUsk_J7&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0#&view-params=%7B%22value%22%3A%22yarrrgh%22%2C%22retVal%22%3A%22%22%7D#rpctoken=jRo0mz&oahParent=http%3A%2F%2Flocalhost%3A8080

        Stanton Sievers wrote:

        That URL is not valid. There can't be two "#" in a URL. It's also weird that the first "#" is followed by "&view-params", almost like the view params are simple being string concatenated. That's the real issue here. Where are you rendering this gadget?

        Stanton, that's a good point. Not sure exactly what you mean by "where" am I rendering it. The gadget is being rendered via a call to gadgets.views.openGadget - does that answer yuor question?

        • Erin

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5113/#review7889
        -----------------------------------------------------------

        On 2012-05-15 12:42:36, Erin Noe-Payne wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/5113/

        -----------------------------------------------------------

        (Updated 2012-05-15 12:42:36)

        Review request for shindig.

        Summary

        -------

        pubsub-2 appends an rpc token with a hashtag to the open gadget url. When the url parameters are split by '&', hash tags are skipped and json.parse fails on the resulting parameter.

        Switched to global replace to avoid the issue.

        This addresses bug SHINDIG-1777.

        https://issues.apache.org/jira/browse/SHINDIG-1777

        Diffs

        -----

        trunk/features/src/main/javascript/features/core.util.urlparams/urlparams.js 1338216

        Diff: https://reviews.apache.org/r/5113/diff

        Testing

        -------

        Chrome, FF 12, IE 8/9

        Thanks,

        Erin

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-05-15 12:28:16, Stanton Sievers wrote: > I'm not seeing how the existing code is causing the issue. Do you have a sample input url to parseUrlParams that causes the issue? Erin Noe-Payne wrote: See an example url below. There are two hash tags in this url, the first being right after &mid=0. The original code will catch only one instance. http://localhost:8080/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fdemogadgets%2Fopen_views_demo.xml&container=default&view=popup&lang=%25lang%25&country=%25country%25&debug=1&nocache=1&sanitize=%25sanitize%25&v=d3083135601a3923d70da1a99b86fc65&st=default%3A-qZ05EIwCF5iJg0uia2gDYagSbzknSSqLsOGSZIDr6w3oVfg6ZHNQ0zD384lF5jO9tsyCsVocN9u9awbccSMC1onXMJv4BHgVIRIvLYGk0w5RWoJWhkskuW-0FlrMtXra3PTNNjjOfXnlUoQjX4Co6S1iC3B1fAleDlxVhiMokUsk_J7&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0#&view-params=%7B%22value%22%3A%22yarrrgh%22%2C%22retVal%22%3A%22%22%7D#rpctoken=jRo0mz&oahParent=http%3A%2F%2Flocalhost%3A8080 Stanton Sievers wrote: That URL is not valid. There can't be two "#" in a URL. It's also weird that the first "#" is followed by "&view-params", almost like the view params are simple being string concatenated. That's the real issue here. Where are you rendering this gadget? Stanton, that's a good point. Not sure exactly what you mean by "where" am I rendering it. The gadget is being rendered via a call to gadgets.views.openGadget - does that answer yuor question? Erin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5113/#review7889 ----------------------------------------------------------- On 2012-05-15 12:42:36, Erin Noe-Payne wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5113/ ----------------------------------------------------------- (Updated 2012-05-15 12:42:36) Review request for shindig. Summary ------- pubsub-2 appends an rpc token with a hashtag to the open gadget url. When the url parameters are split by '&', hash tags are skipped and json.parse fails on the resulting parameter. Switched to global replace to avoid the issue. This addresses bug SHINDIG-1777 . https://issues.apache.org/jira/browse/SHINDIG-1777 Diffs ----- trunk/features/src/main/javascript/features/core.util.urlparams/urlparams.js 1338216 Diff: https://reviews.apache.org/r/5113/diff Testing ------- Chrome, FF 12, IE 8/9 Thanks, Erin
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-05-15 12:28:16, Stanton Sievers wrote:

        > I'm not seeing how the existing code is causing the issue. Do you have a sample input url to parseUrlParams that causes the issue?

        Erin Noe-Payne wrote:

        See an example url below. There are two hash tags in this url, the first being right after &mid=0. The original code will catch only one instance.

        http://localhost:8080/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fdemogadgets%2Fopen_views_demo.xml&container=default&view=popup&lang=%25lang%25&country=%25country%25&debug=1&nocache=1&sanitize=%25sanitize%25&v=d3083135601a3923d70da1a99b86fc65&st=default%3A-qZ05EIwCF5iJg0uia2gDYagSbzknSSqLsOGSZIDr6w3oVfg6ZHNQ0zD384lF5jO9tsyCsVocN9u9awbccSMC1onXMJv4BHgVIRIvLYGk0w5RWoJWhkskuW-0FlrMtXra3PTNNjjOfXnlUoQjX4Co6S1iC3B1fAleDlxVhiMokUsk_J7&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0#&view-params=%7B%22value%22%3A%22yarrrgh%22%2C%22retVal%22%3A%22%22%7D#rpctoken=jRo0mz&oahParent=http%3A%2F%2Flocalhost%3A8080

        Stanton Sievers wrote:

        That URL is not valid. There can't be two "#" in a URL. It's also weird that the first "#" is followed by "&view-params", almost like the view params are simple being string concatenated. That's the real issue here. Where are you rendering this gadget?

        Erin Noe-Payne wrote:

        Stanton, that's a good point. Not sure exactly what you mean by "where" am I rendering it. The gadget is being rendered via a call to gadgets.views.openGadget - does that answer yuor question?

        Stanton Sievers wrote:

        In what container are you rendering this gadget? Can you post your test gadget as well?

        The container is Apache Rave. I'm having trouble connecting to jira to attach the demo gadget - I will do so when I can. The gist of it is requiring these two features:
        <Require feature="open-views"/>
        <Require feature="pubsub-2"/>

        Define two views, one default and one called "popup"
        Then, in the code bind the following to a button click:
        var viewParams =

        {"name":"somevalue"}

        ;
        var opt_params =

        {"view":"popup", "viewTarget":"dialog", "viewParams":viewParams}

        ;
        gadgets.views.openGadget(function(){}, function(){}, opt_params);

        • Erin

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5113/#review7889
        -----------------------------------------------------------

        On 2012-05-15 12:42:36, Erin Noe-Payne wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/5113/

        -----------------------------------------------------------

        (Updated 2012-05-15 12:42:36)

        Review request for shindig.

        Summary

        -------

        pubsub-2 appends an rpc token with a hashtag to the open gadget url. When the url parameters are split by '&', hash tags are skipped and json.parse fails on the resulting parameter.

        Switched to global replace to avoid the issue.

        This addresses bug SHINDIG-1777.

        https://issues.apache.org/jira/browse/SHINDIG-1777

        Diffs

        -----

        trunk/features/src/main/javascript/features/core.util.urlparams/urlparams.js 1338216

        Diff: https://reviews.apache.org/r/5113/diff

        Testing

        -------

        Chrome, FF 12, IE 8/9

        Thanks,

        Erin

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-05-15 12:28:16, Stanton Sievers wrote: > I'm not seeing how the existing code is causing the issue. Do you have a sample input url to parseUrlParams that causes the issue? Erin Noe-Payne wrote: See an example url below. There are two hash tags in this url, the first being right after &mid=0. The original code will catch only one instance. http://localhost:8080/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fdemogadgets%2Fopen_views_demo.xml&container=default&view=popup&lang=%25lang%25&country=%25country%25&debug=1&nocache=1&sanitize=%25sanitize%25&v=d3083135601a3923d70da1a99b86fc65&st=default%3A-qZ05EIwCF5iJg0uia2gDYagSbzknSSqLsOGSZIDr6w3oVfg6ZHNQ0zD384lF5jO9tsyCsVocN9u9awbccSMC1onXMJv4BHgVIRIvLYGk0w5RWoJWhkskuW-0FlrMtXra3PTNNjjOfXnlUoQjX4Co6S1iC3B1fAleDlxVhiMokUsk_J7&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0#&view-params=%7B%22value%22%3A%22yarrrgh%22%2C%22retVal%22%3A%22%22%7D#rpctoken=jRo0mz&oahParent=http%3A%2F%2Flocalhost%3A8080 Stanton Sievers wrote: That URL is not valid. There can't be two "#" in a URL. It's also weird that the first "#" is followed by "&view-params", almost like the view params are simple being string concatenated. That's the real issue here. Where are you rendering this gadget? Erin Noe-Payne wrote: Stanton, that's a good point. Not sure exactly what you mean by "where" am I rendering it. The gadget is being rendered via a call to gadgets.views.openGadget - does that answer yuor question? Stanton Sievers wrote: In what container are you rendering this gadget? Can you post your test gadget as well? The container is Apache Rave. I'm having trouble connecting to jira to attach the demo gadget - I will do so when I can. The gist of it is requiring these two features: <Require feature="open-views"/> <Require feature="pubsub-2"/> Define two views, one default and one called "popup" Then, in the code bind the following to a button click: var viewParams = {"name":"somevalue"} ; var opt_params = {"view":"popup", "viewTarget":"dialog", "viewParams":viewParams} ; gadgets.views.openGadget(function(){}, function(){}, opt_params); Erin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5113/#review7889 ----------------------------------------------------------- On 2012-05-15 12:42:36, Erin Noe-Payne wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5113/ ----------------------------------------------------------- (Updated 2012-05-15 12:42:36) Review request for shindig. Summary ------- pubsub-2 appends an rpc token with a hashtag to the open gadget url. When the url parameters are split by '&', hash tags are skipped and json.parse fails on the resulting parameter. Switched to global replace to avoid the issue. This addresses bug SHINDIG-1777 . https://issues.apache.org/jira/browse/SHINDIG-1777 Diffs ----- trunk/features/src/main/javascript/features/core.util.urlparams/urlparams.js 1338216 Diff: https://reviews.apache.org/r/5113/diff Testing ------- Chrome, FF 12, IE 8/9 Thanks, Erin
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-05-15 12:28:16, Stanton Sievers wrote:

        > I'm not seeing how the existing code is causing the issue. Do you have a sample input url to parseUrlParams that causes the issue?

        Erin Noe-Payne wrote:

        See an example url below. There are two hash tags in this url, the first being right after &mid=0. The original code will catch only one instance.

        http://localhost:8080/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fdemogadgets%2Fopen_views_demo.xml&container=default&view=popup&lang=%25lang%25&country=%25country%25&debug=1&nocache=1&sanitize=%25sanitize%25&v=d3083135601a3923d70da1a99b86fc65&st=default%3A-qZ05EIwCF5iJg0uia2gDYagSbzknSSqLsOGSZIDr6w3oVfg6ZHNQ0zD384lF5jO9tsyCsVocN9u9awbccSMC1onXMJv4BHgVIRIvLYGk0w5RWoJWhkskuW-0FlrMtXra3PTNNjjOfXnlUoQjX4Co6S1iC3B1fAleDlxVhiMokUsk_J7&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0#&view-params=%7B%22value%22%3A%22yarrrgh%22%2C%22retVal%22%3A%22%22%7D#rpctoken=jRo0mz&oahParent=http%3A%2F%2Flocalhost%3A8080

        Stanton Sievers wrote:

        That URL is not valid. There can't be two "#" in a URL. It's also weird that the first "#" is followed by "&view-params", almost like the view params are simple being string concatenated. That's the real issue here. Where are you rendering this gadget?

        Erin Noe-Payne wrote:

        Stanton, that's a good point. Not sure exactly what you mean by "where" am I rendering it. The gadget is being rendered via a call to gadgets.views.openGadget - does that answer yuor question?

        In what container are you rendering this gadget? Can you post your test gadget as well?

        • Stanton

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5113/#review7889
        -----------------------------------------------------------

        On 2012-05-15 12:42:36, Erin Noe-Payne wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/5113/

        -----------------------------------------------------------

        (Updated 2012-05-15 12:42:36)

        Review request for shindig.

        Summary

        -------

        pubsub-2 appends an rpc token with a hashtag to the open gadget url. When the url parameters are split by '&', hash tags are skipped and json.parse fails on the resulting parameter.

        Switched to global replace to avoid the issue.

        This addresses bug SHINDIG-1777.

        https://issues.apache.org/jira/browse/SHINDIG-1777

        Diffs

        -----

        trunk/features/src/main/javascript/features/core.util.urlparams/urlparams.js 1338216

        Diff: https://reviews.apache.org/r/5113/diff

        Testing

        -------

        Chrome, FF 12, IE 8/9

        Thanks,

        Erin

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-05-15 12:28:16, Stanton Sievers wrote: > I'm not seeing how the existing code is causing the issue. Do you have a sample input url to parseUrlParams that causes the issue? Erin Noe-Payne wrote: See an example url below. There are two hash tags in this url, the first being right after &mid=0. The original code will catch only one instance. http://localhost:8080/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fdemogadgets%2Fopen_views_demo.xml&container=default&view=popup&lang=%25lang%25&country=%25country%25&debug=1&nocache=1&sanitize=%25sanitize%25&v=d3083135601a3923d70da1a99b86fc65&st=default%3A-qZ05EIwCF5iJg0uia2gDYagSbzknSSqLsOGSZIDr6w3oVfg6ZHNQ0zD384lF5jO9tsyCsVocN9u9awbccSMC1onXMJv4BHgVIRIvLYGk0w5RWoJWhkskuW-0FlrMtXra3PTNNjjOfXnlUoQjX4Co6S1iC3B1fAleDlxVhiMokUsk_J7&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0#&view-params=%7B%22value%22%3A%22yarrrgh%22%2C%22retVal%22%3A%22%22%7D#rpctoken=jRo0mz&oahParent=http%3A%2F%2Flocalhost%3A8080 Stanton Sievers wrote: That URL is not valid. There can't be two "#" in a URL. It's also weird that the first "#" is followed by "&view-params", almost like the view params are simple being string concatenated. That's the real issue here. Where are you rendering this gadget? Erin Noe-Payne wrote: Stanton, that's a good point. Not sure exactly what you mean by "where" am I rendering it. The gadget is being rendered via a call to gadgets.views.openGadget - does that answer yuor question? In what container are you rendering this gadget? Can you post your test gadget as well? Stanton ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5113/#review7889 ----------------------------------------------------------- On 2012-05-15 12:42:36, Erin Noe-Payne wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5113/ ----------------------------------------------------------- (Updated 2012-05-15 12:42:36) Review request for shindig. Summary ------- pubsub-2 appends an rpc token with a hashtag to the open gadget url. When the url parameters are split by '&', hash tags are skipped and json.parse fails on the resulting parameter. Switched to global replace to avoid the issue. This addresses bug SHINDIG-1777 . https://issues.apache.org/jira/browse/SHINDIG-1777 Diffs ----- trunk/features/src/main/javascript/features/core.util.urlparams/urlparams.js 1338216 Diff: https://reviews.apache.org/r/5113/diff Testing ------- Chrome, FF 12, IE 8/9 Thanks, Erin
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-05-15 12:28:16, Stanton Sievers wrote:

        > I'm not seeing how the existing code is causing the issue. Do you have a sample input url to parseUrlParams that causes the issue?

        Erin Noe-Payne wrote:

        See an example url below. There are two hash tags in this url, the first being right after &mid=0. The original code will catch only one instance.

        http://localhost:8080/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fdemogadgets%2Fopen_views_demo.xml&container=default&view=popup&lang=%25lang%25&country=%25country%25&debug=1&nocache=1&sanitize=%25sanitize%25&v=d3083135601a3923d70da1a99b86fc65&st=default%3A-qZ05EIwCF5iJg0uia2gDYagSbzknSSqLsOGSZIDr6w3oVfg6ZHNQ0zD384lF5jO9tsyCsVocN9u9awbccSMC1onXMJv4BHgVIRIvLYGk0w5RWoJWhkskuW-0FlrMtXra3PTNNjjOfXnlUoQjX4Co6S1iC3B1fAleDlxVhiMokUsk_J7&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0#&view-params=%7B%22value%22%3A%22yarrrgh%22%2C%22retVal%22%3A%22%22%7D#rpctoken=jRo0mz&oahParent=http%3A%2F%2Flocalhost%3A8080

        Stanton Sievers wrote:

        That URL is not valid. There can't be two "#" in a URL. It's also weird that the first "#" is followed by "&view-params", almost like the view params are simple being string concatenated. That's the real issue here. Where are you rendering this gadget?

        Erin Noe-Payne wrote:

        Stanton, that's a good point. Not sure exactly what you mean by "where" am I rendering it. The gadget is being rendered via a call to gadgets.views.openGadget - does that answer yuor question?

        Stanton Sievers wrote:

        In what container are you rendering this gadget? Can you post your test gadget as well?

        Erin Noe-Payne wrote:

        The container is Apache Rave. I'm having trouble connecting to jira to attach the demo gadget - I will do so when I can. The gist of it is requiring these two features:

        <Require feature="open-views"/>

        <Require feature="pubsub-2"/>

        Define two views, one default and one called "popup"

        Then, in the code bind the following to a button click:

        var viewParams = {"name":"somevalue"};

        var opt_params = {"view":"popup", "viewTarget":"dialog", "viewParams":viewParams};

        gadgets.views.openGadget(function(){}, function(){}, opt_params);

        I can reproduce the issue in Shindig's sample common container page. However, the issue seems to be with OAHub and not with Shindig. The url looks good when Shindig is done with it, i.e., at the end of gadget_holder#getIframeUrl()

        //localhost:8080/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fcontainer%2Fsample-open-gadget.xml&container=default&view=popup&lang=en&country=US&debug=1&nocache=1&sanitize=%25sanitize%25&v=95a97135e24a52cad458ce6e6a22ec55&st=john.doe%3Ajohn.doe%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fcontainer%252Fsample-open-gadget.xml%3Acont%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fcontainer%252Fsample-open-gadget.xml%3A0%3Adefault%3A1337099847&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0#view-params=%7B%22name%22%3A%22somevalue%22%7D&rpctoken=1175362355

        I'm not familiar with OAHub, but it looks like it is tacking on the second fragment bit.

        • Stanton

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5113/#review7889
        -----------------------------------------------------------

        On 2012-05-15 12:42:36, Erin Noe-Payne wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/5113/

        -----------------------------------------------------------

        (Updated 2012-05-15 12:42:36)

        Review request for shindig.

        Summary

        -------

        pubsub-2 appends an rpc token with a hashtag to the open gadget url. When the url parameters are split by '&', hash tags are skipped and json.parse fails on the resulting parameter.

        Switched to global replace to avoid the issue.

        This addresses bug SHINDIG-1777.

        https://issues.apache.org/jira/browse/SHINDIG-1777

        Diffs

        -----

        trunk/features/src/main/javascript/features/core.util.urlparams/urlparams.js 1338216

        Diff: https://reviews.apache.org/r/5113/diff

        Testing

        -------

        Chrome, FF 12, IE 8/9

        Thanks,

        Erin

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-05-15 12:28:16, Stanton Sievers wrote: > I'm not seeing how the existing code is causing the issue. Do you have a sample input url to parseUrlParams that causes the issue? Erin Noe-Payne wrote: See an example url below. There are two hash tags in this url, the first being right after &mid=0. The original code will catch only one instance. http://localhost:8080/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fdemogadgets%2Fopen_views_demo.xml&container=default&view=popup&lang=%25lang%25&country=%25country%25&debug=1&nocache=1&sanitize=%25sanitize%25&v=d3083135601a3923d70da1a99b86fc65&st=default%3A-qZ05EIwCF5iJg0uia2gDYagSbzknSSqLsOGSZIDr6w3oVfg6ZHNQ0zD384lF5jO9tsyCsVocN9u9awbccSMC1onXMJv4BHgVIRIvLYGk0w5RWoJWhkskuW-0FlrMtXra3PTNNjjOfXnlUoQjX4Co6S1iC3B1fAleDlxVhiMokUsk_J7&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0#&view-params=%7B%22value%22%3A%22yarrrgh%22%2C%22retVal%22%3A%22%22%7D#rpctoken=jRo0mz&oahParent=http%3A%2F%2Flocalhost%3A8080 Stanton Sievers wrote: That URL is not valid. There can't be two "#" in a URL. It's also weird that the first "#" is followed by "&view-params", almost like the view params are simple being string concatenated. That's the real issue here. Where are you rendering this gadget? Erin Noe-Payne wrote: Stanton, that's a good point. Not sure exactly what you mean by "where" am I rendering it. The gadget is being rendered via a call to gadgets.views.openGadget - does that answer yuor question? Stanton Sievers wrote: In what container are you rendering this gadget? Can you post your test gadget as well? Erin Noe-Payne wrote: The container is Apache Rave. I'm having trouble connecting to jira to attach the demo gadget - I will do so when I can. The gist of it is requiring these two features: <Require feature="open-views"/> <Require feature="pubsub-2"/> Define two views, one default and one called "popup" Then, in the code bind the following to a button click: var viewParams = {"name":"somevalue"}; var opt_params = {"view":"popup", "viewTarget":"dialog", "viewParams":viewParams}; gadgets.views.openGadget(function(){}, function(){}, opt_params); I can reproduce the issue in Shindig's sample common container page. However, the issue seems to be with OAHub and not with Shindig. The url looks good when Shindig is done with it, i.e., at the end of gadget_holder#getIframeUrl() //localhost:8080/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fcontainer%2Fsample-open-gadget.xml&container=default&view=popup&lang=en&country=US&debug=1&nocache=1&sanitize=%25sanitize%25&v=95a97135e24a52cad458ce6e6a22ec55&st=john.doe%3Ajohn.doe%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fcontainer%252Fsample-open-gadget.xml%3Acont%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fcontainer%252Fsample-open-gadget.xml%3A0%3Adefault%3A1337099847&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0#view-params=%7B%22name%22%3A%22somevalue%22%7D&rpctoken=1175362355 I'm not familiar with OAHub, but it looks like it is tacking on the second fragment bit. Stanton ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5113/#review7889 ----------------------------------------------------------- On 2012-05-15 12:42:36, Erin Noe-Payne wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5113/ ----------------------------------------------------------- (Updated 2012-05-15 12:42:36) Review request for shindig. Summary ------- pubsub-2 appends an rpc token with a hashtag to the open gadget url. When the url parameters are split by '&', hash tags are skipped and json.parse fails on the resulting parameter. Switched to global replace to avoid the issue. This addresses bug SHINDIG-1777 . https://issues.apache.org/jira/browse/SHINDIG-1777 Diffs ----- trunk/features/src/main/javascript/features/core.util.urlparams/urlparams.js 1338216 Diff: https://reviews.apache.org/r/5113/diff Testing ------- Chrome, FF 12, IE 8/9 Thanks, Erin
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-05-15 12:28:16, Stanton Sievers wrote:

        > I'm not seeing how the existing code is causing the issue. Do you have a sample input url to parseUrlParams that causes the issue?

        Erin Noe-Payne wrote:

        See an example url below. There are two hash tags in this url, the first being right after &mid=0. The original code will catch only one instance.

        http://localhost:8080/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fdemogadgets%2Fopen_views_demo.xml&container=default&view=popup&lang=%25lang%25&country=%25country%25&debug=1&nocache=1&sanitize=%25sanitize%25&v=d3083135601a3923d70da1a99b86fc65&st=default%3A-qZ05EIwCF5iJg0uia2gDYagSbzknSSqLsOGSZIDr6w3oVfg6ZHNQ0zD384lF5jO9tsyCsVocN9u9awbccSMC1onXMJv4BHgVIRIvLYGk0w5RWoJWhkskuW-0FlrMtXra3PTNNjjOfXnlUoQjX4Co6S1iC3B1fAleDlxVhiMokUsk_J7&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0#&view-params=%7B%22value%22%3A%22yarrrgh%22%2C%22retVal%22%3A%22%22%7D#rpctoken=jRo0mz&oahParent=http%3A%2F%2Flocalhost%3A8080

        Stanton Sievers wrote:

        That URL is not valid. There can't be two "#" in a URL. It's also weird that the first "#" is followed by "&view-params", almost like the view params are simple being string concatenated. That's the real issue here. Where are you rendering this gadget?

        Erin Noe-Payne wrote:

        Stanton, that's a good point. Not sure exactly what you mean by "where" am I rendering it. The gadget is being rendered via a call to gadgets.views.openGadget - does that answer yuor question?

        Stanton Sievers wrote:

        In what container are you rendering this gadget? Can you post your test gadget as well?

        Erin Noe-Payne wrote:

        The container is Apache Rave. I'm having trouble connecting to jira to attach the demo gadget - I will do so when I can. The gist of it is requiring these two features:

        <Require feature="open-views"/>

        <Require feature="pubsub-2"/>

        Define two views, one default and one called "popup"

        Then, in the code bind the following to a button click:

        var viewParams = {"name":"somevalue"};

        var opt_params = {"view":"popup", "viewTarget":"dialog", "viewParams":viewParams};

        gadgets.views.openGadget(function(){}, function(){}, opt_params);

        Stanton Sievers wrote:

        I can reproduce the issue in Shindig's sample common container page. However, the issue seems to be with OAHub and not with Shindig. The url looks good when Shindig is done with it, i.e., at the end of gadget_holder#getIframeUrl()

        //localhost:8080/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fcontainer%2Fsample-open-gadget.xml&container=default&view=popup&lang=en&country=US&debug=1&nocache=1&sanitize=%25sanitize%25&v=95a97135e24a52cad458ce6e6a22ec55&st=john.doe%3Ajohn.doe%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fcontainer%252Fsample-open-gadget.xml%3Acont%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fcontainer%252Fsample-open-gadget.xml%3A0%3Adefault%3A1337099847&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0#view-params=%7B%22name%22%3A%22somevalue%22%7D&rpctoken=1175362355

        I'm not familiar with OAHub, but it looks like it is tacking on the second fragment bit.

        Stanton, I see you are correct - thank you for the help. I have the openajax feature code and see where a correction needs to be made. Can I make this change and update the diff, or is this feature owned by a different project?

        • Erin

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5113/#review7889
        -----------------------------------------------------------

        On 2012-05-15 12:42:36, Erin Noe-Payne wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/5113/

        -----------------------------------------------------------

        (Updated 2012-05-15 12:42:36)

        Review request for shindig.

        Summary

        -------

        pubsub-2 appends an rpc token with a hashtag to the open gadget url. When the url parameters are split by '&', hash tags are skipped and json.parse fails on the resulting parameter.

        Switched to global replace to avoid the issue.

        This addresses bug SHINDIG-1777.

        https://issues.apache.org/jira/browse/SHINDIG-1777

        Diffs

        -----

        trunk/features/src/main/javascript/features/core.util.urlparams/urlparams.js 1338216

        Diff: https://reviews.apache.org/r/5113/diff

        Testing

        -------

        Chrome, FF 12, IE 8/9

        Thanks,

        Erin

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-05-15 12:28:16, Stanton Sievers wrote: > I'm not seeing how the existing code is causing the issue. Do you have a sample input url to parseUrlParams that causes the issue? Erin Noe-Payne wrote: See an example url below. There are two hash tags in this url, the first being right after &mid=0. The original code will catch only one instance. http://localhost:8080/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fdemogadgets%2Fopen_views_demo.xml&container=default&view=popup&lang=%25lang%25&country=%25country%25&debug=1&nocache=1&sanitize=%25sanitize%25&v=d3083135601a3923d70da1a99b86fc65&st=default%3A-qZ05EIwCF5iJg0uia2gDYagSbzknSSqLsOGSZIDr6w3oVfg6ZHNQ0zD384lF5jO9tsyCsVocN9u9awbccSMC1onXMJv4BHgVIRIvLYGk0w5RWoJWhkskuW-0FlrMtXra3PTNNjjOfXnlUoQjX4Co6S1iC3B1fAleDlxVhiMokUsk_J7&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0#&view-params=%7B%22value%22%3A%22yarrrgh%22%2C%22retVal%22%3A%22%22%7D#rpctoken=jRo0mz&oahParent=http%3A%2F%2Flocalhost%3A8080 Stanton Sievers wrote: That URL is not valid. There can't be two "#" in a URL. It's also weird that the first "#" is followed by "&view-params", almost like the view params are simple being string concatenated. That's the real issue here. Where are you rendering this gadget? Erin Noe-Payne wrote: Stanton, that's a good point. Not sure exactly what you mean by "where" am I rendering it. The gadget is being rendered via a call to gadgets.views.openGadget - does that answer yuor question? Stanton Sievers wrote: In what container are you rendering this gadget? Can you post your test gadget as well? Erin Noe-Payne wrote: The container is Apache Rave. I'm having trouble connecting to jira to attach the demo gadget - I will do so when I can. The gist of it is requiring these two features: <Require feature="open-views"/> <Require feature="pubsub-2"/> Define two views, one default and one called "popup" Then, in the code bind the following to a button click: var viewParams = {"name":"somevalue"}; var opt_params = {"view":"popup", "viewTarget":"dialog", "viewParams":viewParams}; gadgets.views.openGadget(function(){}, function(){}, opt_params); Stanton Sievers wrote: I can reproduce the issue in Shindig's sample common container page. However, the issue seems to be with OAHub and not with Shindig. The url looks good when Shindig is done with it, i.e., at the end of gadget_holder#getIframeUrl() //localhost:8080/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fcontainer%2Fsample-open-gadget.xml&container=default&view=popup&lang=en&country=US&debug=1&nocache=1&sanitize=%25sanitize%25&v=95a97135e24a52cad458ce6e6a22ec55&st=john.doe%3Ajohn.doe%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fcontainer%252Fsample-open-gadget.xml%3Acont%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fcontainer%252Fsample-open-gadget.xml%3A0%3Adefault%3A1337099847&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0#view-params=%7B%22name%22%3A%22somevalue%22%7D&rpctoken=1175362355 I'm not familiar with OAHub, but it looks like it is tacking on the second fragment bit. Stanton, I see you are correct - thank you for the help. I have the openajax feature code and see where a correction needs to be made. Can I make this change and update the diff, or is this feature owned by a different project? Erin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5113/#review7889 ----------------------------------------------------------- On 2012-05-15 12:42:36, Erin Noe-Payne wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5113/ ----------------------------------------------------------- (Updated 2012-05-15 12:42:36) Review request for shindig. Summary ------- pubsub-2 appends an rpc token with a hashtag to the open gadget url. When the url parameters are split by '&', hash tags are skipped and json.parse fails on the resulting parameter. Switched to global replace to avoid the issue. This addresses bug SHINDIG-1777 . https://issues.apache.org/jira/browse/SHINDIG-1777 Diffs ----- trunk/features/src/main/javascript/features/core.util.urlparams/urlparams.js 1338216 Diff: https://reviews.apache.org/r/5113/diff Testing ------- Chrome, FF 12, IE 8/9 Thanks, Erin
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5113/
        -----------------------------------------------------------

        (Updated 2012-05-15 19:14:23.017767)

        Review request for shindig.

        Changes
        -------

        edited openajax feature to check for presence of hash in url before appending rpctoken

        Summary
        -------

        pubsub-2 appends an rpc token with a hashtag to the open gadget url. When the url parameters are split by '&', hash tags are skipped and json.parse fails on the resulting parameter.

        Switched to global replace to avoid the issue.

        This addresses bug SHINDIG-1777.
        https://issues.apache.org/jira/browse/SHINDIG-1777

        Diffs (updated)


        trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js 1338216

        Diff: https://reviews.apache.org/r/5113/diff

        Testing
        -------

        Chrome, FF 12, IE 8/9

        Thanks,

        Erin

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5113/ ----------------------------------------------------------- (Updated 2012-05-15 19:14:23.017767) Review request for shindig. Changes ------- edited openajax feature to check for presence of hash in url before appending rpctoken Summary ------- pubsub-2 appends an rpc token with a hashtag to the open gadget url. When the url parameters are split by '&', hash tags are skipped and json.parse fails on the resulting parameter. Switched to global replace to avoid the issue. This addresses bug SHINDIG-1777 . https://issues.apache.org/jira/browse/SHINDIG-1777 Diffs (updated) trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js 1338216 Diff: https://reviews.apache.org/r/5113/diff Testing ------- Chrome, FF 12, IE 8/9 Thanks, Erin
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5113/#review7930
        -----------------------------------------------------------

        New patch lgtm

        • Dan

        On 2012-05-15 19:14:23, Erin Noe-Payne wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/5113/

        -----------------------------------------------------------

        (Updated 2012-05-15 19:14:23)

        Review request for shindig.

        Summary

        -------

        pubsub-2 appends an rpc token with a hashtag to the open gadget url. When the url parameters are split by '&', hash tags are skipped and json.parse fails on the resulting parameter.

        Switched to global replace to avoid the issue.

        This addresses bug SHINDIG-1777.

        https://issues.apache.org/jira/browse/SHINDIG-1777

        Diffs

        -----

        trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js 1338216

        Diff: https://reviews.apache.org/r/5113/diff

        Testing

        -------

        Chrome, FF 12, IE 8/9

        Thanks,

        Erin

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5113/#review7930 ----------------------------------------------------------- New patch lgtm Dan On 2012-05-15 19:14:23, Erin Noe-Payne wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5113/ ----------------------------------------------------------- (Updated 2012-05-15 19:14:23) Review request for shindig. Summary ------- pubsub-2 appends an rpc token with a hashtag to the open gadget url. When the url parameters are split by '&', hash tags are skipped and json.parse fails on the resulting parameter. Switched to global replace to avoid the issue. This addresses bug SHINDIG-1777 . https://issues.apache.org/jira/browse/SHINDIG-1777 Diffs ----- trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js 1338216 Diff: https://reviews.apache.org/r/5113/diff Testing ------- Chrome, FF 12, IE 8/9 Thanks, Erin
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-05-15 12:28:16, Stanton Sievers wrote:

        > I'm not seeing how the existing code is causing the issue. Do you have a sample input url to parseUrlParams that causes the issue?

        Erin Noe-Payne wrote:

        See an example url below. There are two hash tags in this url, the first being right after &mid=0. The original code will catch only one instance.

        http://localhost:8080/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fdemogadgets%2Fopen_views_demo.xml&container=default&view=popup&lang=%25lang%25&country=%25country%25&debug=1&nocache=1&sanitize=%25sanitize%25&v=d3083135601a3923d70da1a99b86fc65&st=default%3A-qZ05EIwCF5iJg0uia2gDYagSbzknSSqLsOGSZIDr6w3oVfg6ZHNQ0zD384lF5jO9tsyCsVocN9u9awbccSMC1onXMJv4BHgVIRIvLYGk0w5RWoJWhkskuW-0FlrMtXra3PTNNjjOfXnlUoQjX4Co6S1iC3B1fAleDlxVhiMokUsk_J7&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0#&view-params=%7B%22value%22%3A%22yarrrgh%22%2C%22retVal%22%3A%22%22%7D#rpctoken=jRo0mz&oahParent=http%3A%2F%2Flocalhost%3A8080

        Stanton Sievers wrote:

        That URL is not valid. There can't be two "#" in a URL. It's also weird that the first "#" is followed by "&view-params", almost like the view params are simple being string concatenated. That's the real issue here. Where are you rendering this gadget?

        Erin Noe-Payne wrote:

        Stanton, that's a good point. Not sure exactly what you mean by "where" am I rendering it. The gadget is being rendered via a call to gadgets.views.openGadget - does that answer yuor question?

        Stanton Sievers wrote:

        In what container are you rendering this gadget? Can you post your test gadget as well?

        Erin Noe-Payne wrote:

        The container is Apache Rave. I'm having trouble connecting to jira to attach the demo gadget - I will do so when I can. The gist of it is requiring these two features:

        <Require feature="open-views"/>

        <Require feature="pubsub-2"/>

        Define two views, one default and one called "popup"

        Then, in the code bind the following to a button click:

        var viewParams = {"name":"somevalue"};

        var opt_params = {"view":"popup", "viewTarget":"dialog", "viewParams":viewParams};

        gadgets.views.openGadget(function(){}, function(){}, opt_params);

        Stanton Sievers wrote:

        I can reproduce the issue in Shindig's sample common container page. However, the issue seems to be with OAHub and not with Shindig. The url looks good when Shindig is done with it, i.e., at the end of gadget_holder#getIframeUrl()

        //localhost:8080/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fcontainer%2Fsample-open-gadget.xml&container=default&view=popup&lang=en&country=US&debug=1&nocache=1&sanitize=%25sanitize%25&v=95a97135e24a52cad458ce6e6a22ec55&st=john.doe%3Ajohn.doe%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fcontainer%252Fsample-open-gadget.xml%3Acont%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fcontainer%252Fsample-open-gadget.xml%3A0%3Adefault%3A1337099847&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0#view-params=%7B%22name%22%3A%22somevalue%22%7D&rpctoken=1175362355

        I'm not familiar with OAHub, but it looks like it is tacking on the second fragment bit.

        Erin Noe-Payne wrote:

        Stanton, I see you are correct - thank you for the help. I have the openajax feature code and see where a correction needs to be made. Can I make this change and update the diff, or is this feature owned by a different project?

        Excellent question. I'm not sure how we manage changes to the org.openajax.hub code in Shindig's features-extras. Hoping one of the other committers can give some guidance on this...

        Forgot to publish this review yesterday.

        • Stanton

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5113/#review7889
        -----------------------------------------------------------

        On 2012-05-15 19:14:23, Erin Noe-Payne wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/5113/

        -----------------------------------------------------------

        (Updated 2012-05-15 19:14:23)

        Review request for shindig.

        Summary

        -------

        pubsub-2 appends an rpc token with a hashtag to the open gadget url. When the url parameters are split by '&', hash tags are skipped and json.parse fails on the resulting parameter.

        Switched to global replace to avoid the issue.

        This addresses bug SHINDIG-1777.

        https://issues.apache.org/jira/browse/SHINDIG-1777

        Diffs

        -----

        trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js 1338216

        Diff: https://reviews.apache.org/r/5113/diff

        Testing

        -------

        Chrome, FF 12, IE 8/9

        Thanks,

        Erin

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-05-15 12:28:16, Stanton Sievers wrote: > I'm not seeing how the existing code is causing the issue. Do you have a sample input url to parseUrlParams that causes the issue? Erin Noe-Payne wrote: See an example url below. There are two hash tags in this url, the first being right after &mid=0. The original code will catch only one instance. http://localhost:8080/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fdemogadgets%2Fopen_views_demo.xml&container=default&view=popup&lang=%25lang%25&country=%25country%25&debug=1&nocache=1&sanitize=%25sanitize%25&v=d3083135601a3923d70da1a99b86fc65&st=default%3A-qZ05EIwCF5iJg0uia2gDYagSbzknSSqLsOGSZIDr6w3oVfg6ZHNQ0zD384lF5jO9tsyCsVocN9u9awbccSMC1onXMJv4BHgVIRIvLYGk0w5RWoJWhkskuW-0FlrMtXra3PTNNjjOfXnlUoQjX4Co6S1iC3B1fAleDlxVhiMokUsk_J7&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0#&view-params=%7B%22value%22%3A%22yarrrgh%22%2C%22retVal%22%3A%22%22%7D#rpctoken=jRo0mz&oahParent=http%3A%2F%2Flocalhost%3A8080 Stanton Sievers wrote: That URL is not valid. There can't be two "#" in a URL. It's also weird that the first "#" is followed by "&view-params", almost like the view params are simple being string concatenated. That's the real issue here. Where are you rendering this gadget? Erin Noe-Payne wrote: Stanton, that's a good point. Not sure exactly what you mean by "where" am I rendering it. The gadget is being rendered via a call to gadgets.views.openGadget - does that answer yuor question? Stanton Sievers wrote: In what container are you rendering this gadget? Can you post your test gadget as well? Erin Noe-Payne wrote: The container is Apache Rave. I'm having trouble connecting to jira to attach the demo gadget - I will do so when I can. The gist of it is requiring these two features: <Require feature="open-views"/> <Require feature="pubsub-2"/> Define two views, one default and one called "popup" Then, in the code bind the following to a button click: var viewParams = {"name":"somevalue"}; var opt_params = {"view":"popup", "viewTarget":"dialog", "viewParams":viewParams}; gadgets.views.openGadget(function(){}, function(){}, opt_params); Stanton Sievers wrote: I can reproduce the issue in Shindig's sample common container page. However, the issue seems to be with OAHub and not with Shindig. The url looks good when Shindig is done with it, i.e., at the end of gadget_holder#getIframeUrl() //localhost:8080/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fcontainer%2Fsample-open-gadget.xml&container=default&view=popup&lang=en&country=US&debug=1&nocache=1&sanitize=%25sanitize%25&v=95a97135e24a52cad458ce6e6a22ec55&st=john.doe%3Ajohn.doe%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fcontainer%252Fsample-open-gadget.xml%3Acont%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fcontainer%252Fsample-open-gadget.xml%3A0%3Adefault%3A1337099847&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0#view-params=%7B%22name%22%3A%22somevalue%22%7D&rpctoken=1175362355 I'm not familiar with OAHub, but it looks like it is tacking on the second fragment bit. Erin Noe-Payne wrote: Stanton, I see you are correct - thank you for the help. I have the openajax feature code and see where a correction needs to be made. Can I make this change and update the diff, or is this feature owned by a different project? Excellent question. I'm not sure how we manage changes to the org.openajax.hub code in Shindig's features-extras. Hoping one of the other committers can give some guidance on this... Forgot to publish this review yesterday. Stanton ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5113/#review7889 ----------------------------------------------------------- On 2012-05-15 19:14:23, Erin Noe-Payne wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5113/ ----------------------------------------------------------- (Updated 2012-05-15 19:14:23) Review request for shindig. Summary ------- pubsub-2 appends an rpc token with a hashtag to the open gadget url. When the url parameters are split by '&', hash tags are skipped and json.parse fails on the resulting parameter. Switched to global replace to avoid the issue. This addresses bug SHINDIG-1777 . https://issues.apache.org/jira/browse/SHINDIG-1777 Diffs ----- trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js 1338216 Diff: https://reviews.apache.org/r/5113/diff Testing ------- Chrome, FF 12, IE 8/9 Thanks, Erin
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-05-15 12:28:16, Stanton Sievers wrote:

        > I'm not seeing how the existing code is causing the issue. Do you have a sample input url to parseUrlParams that causes the issue?

        Erin Noe-Payne wrote:

        See an example url below. There are two hash tags in this url, the first being right after &mid=0. The original code will catch only one instance.

        http://localhost:8080/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fdemogadgets%2Fopen_views_demo.xml&container=default&view=popup&lang=%25lang%25&country=%25country%25&debug=1&nocache=1&sanitize=%25sanitize%25&v=d3083135601a3923d70da1a99b86fc65&st=default%3A-qZ05EIwCF5iJg0uia2gDYagSbzknSSqLsOGSZIDr6w3oVfg6ZHNQ0zD384lF5jO9tsyCsVocN9u9awbccSMC1onXMJv4BHgVIRIvLYGk0w5RWoJWhkskuW-0FlrMtXra3PTNNjjOfXnlUoQjX4Co6S1iC3B1fAleDlxVhiMokUsk_J7&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0#&view-params=%7B%22value%22%3A%22yarrrgh%22%2C%22retVal%22%3A%22%22%7D#rpctoken=jRo0mz&oahParent=http%3A%2F%2Flocalhost%3A8080

        Stanton Sievers wrote:

        That URL is not valid. There can't be two "#" in a URL. It's also weird that the first "#" is followed by "&view-params", almost like the view params are simple being string concatenated. That's the real issue here. Where are you rendering this gadget?

        Erin Noe-Payne wrote:

        Stanton, that's a good point. Not sure exactly what you mean by "where" am I rendering it. The gadget is being rendered via a call to gadgets.views.openGadget - does that answer yuor question?

        Stanton Sievers wrote:

        In what container are you rendering this gadget? Can you post your test gadget as well?

        Erin Noe-Payne wrote:

        The container is Apache Rave. I'm having trouble connecting to jira to attach the demo gadget - I will do so when I can. The gist of it is requiring these two features:

        <Require feature="open-views"/>

        <Require feature="pubsub-2"/>

        Define two views, one default and one called "popup"

        Then, in the code bind the following to a button click:

        var viewParams = {"name":"somevalue"};

        var opt_params = {"view":"popup", "viewTarget":"dialog", "viewParams":viewParams};

        gadgets.views.openGadget(function(){}, function(){}, opt_params);

        Stanton Sievers wrote:

        I can reproduce the issue in Shindig's sample common container page. However, the issue seems to be with OAHub and not with Shindig. The url looks good when Shindig is done with it, i.e., at the end of gadget_holder#getIframeUrl()

        //localhost:8080/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fcontainer%2Fsample-open-gadget.xml&container=default&view=popup&lang=en&country=US&debug=1&nocache=1&sanitize=%25sanitize%25&v=95a97135e24a52cad458ce6e6a22ec55&st=john.doe%3Ajohn.doe%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fcontainer%252Fsample-open-gadget.xml%3Acont%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fcontainer%252Fsample-open-gadget.xml%3A0%3Adefault%3A1337099847&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0#view-params=%7B%22name%22%3A%22somevalue%22%7D&rpctoken=1175362355

        I'm not familiar with OAHub, but it looks like it is tacking on the second fragment bit.

        Erin Noe-Payne wrote:

        Stanton, I see you are correct - thank you for the help. I have the openajax feature code and see where a correction needs to be made. Can I make this change and update the diff, or is this feature owned by a different project?

        Stanton Sievers wrote:

        Excellent question. I'm not sure how we manage changes to the org.openajax.hub code in Shindig's features-extras. Hoping one of the other committers can give some guidance on this...

        Forgot to publish this review yesterday.

        I would guess the src originally came from the OpenAjax project on Sourceforge [1]. However I am not sure if it was modified at all before being placed in Shindig.

        [1] http://sourceforge.net/projects/openajaxallianc/files/OpenAjaxHub/

        • Ryan

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5113/#review7889
        -----------------------------------------------------------

        On 2012-05-15 19:14:23, Erin Noe-Payne wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/5113/

        -----------------------------------------------------------

        (Updated 2012-05-15 19:14:23)

        Review request for shindig.

        Summary

        -------

        pubsub-2 appends an rpc token with a hashtag to the open gadget url. When the url parameters are split by '&', hash tags are skipped and json.parse fails on the resulting parameter.

        Switched to global replace to avoid the issue.

        This addresses bug SHINDIG-1777.

        https://issues.apache.org/jira/browse/SHINDIG-1777

        Diffs

        -----

        trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js 1338216

        Diff: https://reviews.apache.org/r/5113/diff

        Testing

        -------

        Chrome, FF 12, IE 8/9

        Thanks,

        Erin

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-05-15 12:28:16, Stanton Sievers wrote: > I'm not seeing how the existing code is causing the issue. Do you have a sample input url to parseUrlParams that causes the issue? Erin Noe-Payne wrote: See an example url below. There are two hash tags in this url, the first being right after &mid=0. The original code will catch only one instance. http://localhost:8080/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fdemogadgets%2Fopen_views_demo.xml&container=default&view=popup&lang=%25lang%25&country=%25country%25&debug=1&nocache=1&sanitize=%25sanitize%25&v=d3083135601a3923d70da1a99b86fc65&st=default%3A-qZ05EIwCF5iJg0uia2gDYagSbzknSSqLsOGSZIDr6w3oVfg6ZHNQ0zD384lF5jO9tsyCsVocN9u9awbccSMC1onXMJv4BHgVIRIvLYGk0w5RWoJWhkskuW-0FlrMtXra3PTNNjjOfXnlUoQjX4Co6S1iC3B1fAleDlxVhiMokUsk_J7&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0#&view-params=%7B%22value%22%3A%22yarrrgh%22%2C%22retVal%22%3A%22%22%7D#rpctoken=jRo0mz&oahParent=http%3A%2F%2Flocalhost%3A8080 Stanton Sievers wrote: That URL is not valid. There can't be two "#" in a URL. It's also weird that the first "#" is followed by "&view-params", almost like the view params are simple being string concatenated. That's the real issue here. Where are you rendering this gadget? Erin Noe-Payne wrote: Stanton, that's a good point. Not sure exactly what you mean by "where" am I rendering it. The gadget is being rendered via a call to gadgets.views.openGadget - does that answer yuor question? Stanton Sievers wrote: In what container are you rendering this gadget? Can you post your test gadget as well? Erin Noe-Payne wrote: The container is Apache Rave. I'm having trouble connecting to jira to attach the demo gadget - I will do so when I can. The gist of it is requiring these two features: <Require feature="open-views"/> <Require feature="pubsub-2"/> Define two views, one default and one called "popup" Then, in the code bind the following to a button click: var viewParams = {"name":"somevalue"}; var opt_params = {"view":"popup", "viewTarget":"dialog", "viewParams":viewParams}; gadgets.views.openGadget(function(){}, function(){}, opt_params); Stanton Sievers wrote: I can reproduce the issue in Shindig's sample common container page. However, the issue seems to be with OAHub and not with Shindig. The url looks good when Shindig is done with it, i.e., at the end of gadget_holder#getIframeUrl() //localhost:8080/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fcontainer%2Fsample-open-gadget.xml&container=default&view=popup&lang=en&country=US&debug=1&nocache=1&sanitize=%25sanitize%25&v=95a97135e24a52cad458ce6e6a22ec55&st=john.doe%3Ajohn.doe%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fcontainer%252Fsample-open-gadget.xml%3Acont%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fcontainer%252Fsample-open-gadget.xml%3A0%3Adefault%3A1337099847&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0#view-params=%7B%22name%22%3A%22somevalue%22%7D&rpctoken=1175362355 I'm not familiar with OAHub, but it looks like it is tacking on the second fragment bit. Erin Noe-Payne wrote: Stanton, I see you are correct - thank you for the help. I have the openajax feature code and see where a correction needs to be made. Can I make this change and update the diff, or is this feature owned by a different project? Stanton Sievers wrote: Excellent question. I'm not sure how we manage changes to the org.openajax.hub code in Shindig's features-extras. Hoping one of the other committers can give some guidance on this... Forgot to publish this review yesterday. I would guess the src originally came from the OpenAjax project on Sourceforge [1] . However I am not sure if it was modified at all before being placed in Shindig. [1] http://sourceforge.net/projects/openajaxallianc/files/OpenAjaxHub/ Ryan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5113/#review7889 ----------------------------------------------------------- On 2012-05-15 19:14:23, Erin Noe-Payne wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5113/ ----------------------------------------------------------- (Updated 2012-05-15 19:14:23) Review request for shindig. Summary ------- pubsub-2 appends an rpc token with a hashtag to the open gadget url. When the url parameters are split by '&', hash tags are skipped and json.parse fails on the resulting parameter. Switched to global replace to avoid the issue. This addresses bug SHINDIG-1777 . https://issues.apache.org/jira/browse/SHINDIG-1777 Diffs ----- trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js 1338216 Diff: https://reviews.apache.org/r/5113/diff Testing ------- Chrome, FF 12, IE 8/9 Thanks, Erin
        Hide
        Erin Noe-Payne added a comment -

        Patch for issue fix.

        Show
        Erin Noe-Payne added a comment - Patch for issue fix.
        Hide
        Erin Noe-Payne added a comment -

        Fixed with 1777.patch

        Show
        Erin Noe-Payne added a comment - Fixed with 1777.patch

          People

          • Assignee:
            Unassigned
            Reporter:
            Erin Noe-Payne
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 8h
              8h
              Remaining:
              Remaining Estimate - 8h
              8h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development