Uploaded image for project: 'Shindig'
  1. Shindig
  2. SHINDIG-1771

Closure compile all feature JavaScript as part of JUnit execution to ensure no JavaScript errors at build time

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.5.0-beta2
    • Java, Javascript
    • None

    Description

      At runtime, feature JavaScript is closure compiled at varying compilation levels depending on settings in shindig.properties and other debug flags. If there are compile errors, closure will return an error and this will eventually result in an error back to the client that requested the features.

      A better approach would be to compile each feature at build time as part of the JUnit execution and report errors there. This would allow any JavaScript errors to be caught at build time instead of runtime.

      To be clear, I'm not recommending a change to any of the runtime compilation behavior. That would stay exactly the same. This is simply extra testing we can do at build time to find errors.

      Attachments

        1. shindig-1771.patch
          5 kB
          Stanton Sievers

        Activity

          People

            ssievers Stanton Sievers
            ssievers Stanton Sievers
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: