Uploaded image for project: 'Shindig'
  1. Shindig
  2. SHINDIG-1712

Cleanup open view APIs

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 3.0.0
    • 2.5.0-beta1
    • None
    • None

    Description

      There are several things that need to be cleaned up.

      1. Recent changes to how RPC handlers are handled broke the RPC handler functions. Changes in the context in which the functions are run changed the value of this.
      2. Timing issues in sample gadget caused javascript errors when closing dialogs.
      3. When closing a dialog without pressing cancel or ok caused osapi errors because there was no media item to update.
      4. Use of console.log instead of using gadgets.log in sample gadget
      5. Always pass the relative element whenever the gadgets.views.open* APIs are called.
      6. Pass the gadget metadata to createElementForEmbeddedExperience when the EE data model has a gadget in it.

      Attachments

        1. issue-1712.patch
          22 kB
          Ryan Baxter

        Activity

          People

            rbaxter Ryan Baxter
            rbaxter Ryan Baxter
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: