Shindig
  1. Shindig
  2. SHINDIG-1677

Fix the REST response for collection to wrap it with "list" field

    Details

      Description

      From the data spec 2.0, collection field need to be wrapped with "list" filed. The JSON-RPC endpoints already doing it correctly but the REST endpoints response havent.

      1. SHINDIG-1677.patch
        32 kB
        Henry Saputra

        Issue Links

          Activity

          Hide
          Ryan Baxter added a comment -

          Henry do you know when you will get a chance to address this?

          Show
          Ryan Baxter added a comment - Henry do you know when you will get a chance to address this?
          Hide
          Henry Saputra added a comment -

          ETA is 4/18. Are we planning to release 2.5-beta2 soon?

          Show
          Henry Saputra added a comment - ETA is 4/18. Are we planning to release 2.5-beta2 soon?
          Hide
          Ryan Baxter added a comment -

          We can release whenever we want

          Show
          Ryan Baxter added a comment - We can release whenever we want
          Hide
          Henry Saputra added a comment -

          Before:

          JSON:

          {"entry":[{"name":

          {"givenName":"John","formatted":"John Doe","familyName":"Doe"}

          ,"id":"john.doe"},{"name":

          {"givenName":"Jane","formatted":"Jane Doe","familyName":"Doe"}

          ,"id":"jane.doe"},{"name":

          {"givenName":"George","formatted":"George Doe","familyName":"Doe"}

          ,"id":"george.doe"},{"name":

          {"givenName":"Maija","formatted":"Maija Meikäläinen","familyName":"Meikäläinen"}

          ,"id":"maija.m"}],"totalResults":4,"startIndex":0,"itemsPerPage":4}

          XML:
          <response>
          <itemsPerPage>4</itemsPerPage><startIndex>0</startIndex><totalResults>4</totalResults><filtered>false</filtered><sorted>false</sorted><updatedSince>false</updatedSince>
          <entry><person><id>john.doe</id><name><familyName>Doe</familyName><formatted>John Doe</formatted><givenName>John</givenName></name></person></entry><entry><person><id>jane.doe</id><name><familyName>Doe</familyName><formatted>Jane Doe</formatted><givenName>Jane</givenName></name></person></entry><entry><person><id>george.doe</id><name><familyName>Doe</familyName><formatted>George Doe</formatted><givenName>George</givenName></name></person></entry><entry><person><id>maija.m</id><name><familyName>Meikäläinen</familyName><formatted>Maija Meikäläinen</formatted><givenName>Maija</givenName></name></person></entry></response>

          Atom:

          <feed xmlns="http://www.w3.org/2005/Atom" xmlns:osearch="http://a9.com/-/spec/opensearch/1.1">
          <entry>
          <id>urn:guid:john.doe</id>
          <content type="application/xml">
          <person xmlns="http://ns.opensocial.org/2008/opensocial">
          <id>john.doe</id>
          <name>
          <familyName>Doe</familyName>
          <formatted>John Doe</formatted>
          <givenName>John</givenName>
          </name>
          </person>
          </content>
          </entry>
          <entry>
          <id>urn:guid:jane.doe</id>
          <content type="application/xml">
          <person xmlns="http://ns.opensocial.org/2008/opensocial">
          <id>jane.doe</id>
          <name>
          <familyName>Doe</familyName>
          <formatted>Jane Doe</formatted>
          <givenName>Jane</givenName>
          </name>
          </person>
          </content>
          </entry>
          <entry>
          <id>urn:guid:george.doe</id>
          <content type="application/xml">
          <person xmlns="http://ns.opensocial.org/2008/opensocial">
          <id>george.doe</id>
          <name>
          <familyName>Doe</familyName>
          <formatted>George Doe</formatted>
          <givenName>George</givenName>
          </name>
          </person>
          </content>
          </entry>
          <entry>
          <id>urn:guid:maija.m</id>
          <content type="application/xml">
          <person xmlns="http://ns.opensocial.org/2008/opensocial">
          <id>maija.m</id>
          <name>
          <familyName>Meikäläinen</familyName>
          <formatted>Maija Meikäläinen</formatted>
          <givenName>Maija</givenName>
          </name>
          </person>
          </content>
          </entry>
          <osearch:startIndex>0</osearch:startIndex>
          <osearch:totalResults>4</osearch:totalResults>
          <osearch:itemsPerPage>4</osearch:itemsPerPage>
          <author>?</author>
          <link rel="rel">???</link>
          </feed>

          Show
          Henry Saputra added a comment - Before: JSON: {"entry":[{"name": {"givenName":"John","formatted":"John Doe","familyName":"Doe"} ,"id":"john.doe"},{"name": {"givenName":"Jane","formatted":"Jane Doe","familyName":"Doe"} ,"id":"jane.doe"},{"name": {"givenName":"George","formatted":"George Doe","familyName":"Doe"} ,"id":"george.doe"},{"name": {"givenName":"Maija","formatted":"Maija Meikäläinen","familyName":"Meikäläinen"} ,"id":"maija.m"}],"totalResults":4,"startIndex":0,"itemsPerPage":4} XML: <response> <itemsPerPage>4</itemsPerPage><startIndex>0</startIndex><totalResults>4</totalResults><filtered>false</filtered><sorted>false</sorted><updatedSince>false</updatedSince> <entry><person><id>john.doe</id><name><familyName>Doe</familyName><formatted>John Doe</formatted><givenName>John</givenName></name></person></entry><entry><person><id>jane.doe</id><name><familyName>Doe</familyName><formatted>Jane Doe</formatted><givenName>Jane</givenName></name></person></entry><entry><person><id>george.doe</id><name><familyName>Doe</familyName><formatted>George Doe</formatted><givenName>George</givenName></name></person></entry><entry><person><id>maija.m</id><name><familyName>Meikäläinen</familyName><formatted>Maija Meikäläinen</formatted><givenName>Maija</givenName></name></person></entry></response> Atom: <feed xmlns="http://www.w3.org/2005/Atom" xmlns:osearch="http://a9.com/-/spec/opensearch/1.1"> <entry> <id>urn:guid:john.doe</id> <content type="application/xml"> <person xmlns="http://ns.opensocial.org/2008/opensocial"> <id>john.doe</id> <name> <familyName>Doe</familyName> <formatted>John Doe</formatted> <givenName>John</givenName> </name> </person> </content> </entry> <entry> <id>urn:guid:jane.doe</id> <content type="application/xml"> <person xmlns="http://ns.opensocial.org/2008/opensocial"> <id>jane.doe</id> <name> <familyName>Doe</familyName> <formatted>Jane Doe</formatted> <givenName>Jane</givenName> </name> </person> </content> </entry> <entry> <id>urn:guid:george.doe</id> <content type="application/xml"> <person xmlns="http://ns.opensocial.org/2008/opensocial"> <id>george.doe</id> <name> <familyName>Doe</familyName> <formatted>George Doe</formatted> <givenName>George</givenName> </name> </person> </content> </entry> <entry> <id>urn:guid:maija.m</id> <content type="application/xml"> <person xmlns="http://ns.opensocial.org/2008/opensocial"> <id>maija.m</id> <name> <familyName>Meikäläinen</familyName> <formatted>Maija Meikäläinen</formatted> <givenName>Maija</givenName> </name> </person> </content> </entry> <osearch:startIndex>0</osearch:startIndex> <osearch:totalResults>4</osearch:totalResults> <osearch:itemsPerPage>4</osearch:itemsPerPage> <author>?</author> <link rel="rel">???</link> </feed>
          Hide
          Henry Saputra added a comment -

          After:

          JSON:

          {"list":[{"name":

          {"givenName":"John","formatted":"John Doe","familyName":"Doe"}

          ,"id":"john.doe"},{"name":

          {"givenName":"Jane","formatted":"Jane Doe","familyName":"Doe"}

          ,"id":"jane.doe"},{"name":

          {"givenName":"George","formatted":"George Doe","familyName":"Doe"}

          ,"id":"george.doe"},{"name":

          {"givenName":"Maija","formatted":"Maija Meikäläinen","familyName":"Meikäläinen"}

          ,"id":"maija.m"}],"totalResults":4,"startIndex":0,"itemsPerPage":4}

          XML:
          <response>
          <itemsPerPage>4</itemsPerPage><startIndex>0</startIndex><totalResults>4</totalResults><filtered>false</filtered><sorted>false</sorted><updatedSince>false</updatedSince>
          <list>
          <entry><person><id>john.doe</id><name><familyName>Doe</familyName><formatted>John Doe</formatted><givenName>John</givenName></name></person></entry><entry><person><id>jane.doe</id><name><familyName>Doe</familyName><formatted>Jane Doe</formatted><givenName>Jane</givenName></name></person></entry><entry><person><id>george.doe</id><name><familyName>Doe</familyName><formatted>George Doe</formatted><givenName>George</givenName></name></person></entry><entry><person><id>maija.m</id><name><familyName>Meikäläinen</familyName><formatted>Maija Meikäläinen</formatted><givenName>Maija</givenName></name></person></entry>
          </list>
          </response>

          Atom:

          <feed xmlns="http://www.w3.org/2005/Atom" xmlns:osearch="http://a9.com/-/spec/opensearch/1.1">
          <entry>
          <id>urn:guid:john.doe</id>
          <content type="application/xml">
          <person xmlns="http://ns.opensocial.org/2008/opensocial">
          <id>john.doe</id>
          <name>
          <familyName>Doe</familyName>
          <formatted>John Doe</formatted>
          <givenName>John</givenName>
          </name>
          </person>
          </content>
          </entry>
          <entry>
          <id>urn:guid:jane.doe</id>
          <content type="application/xml">
          <person xmlns="http://ns.opensocial.org/2008/opensocial">
          <id>jane.doe</id>
          <name>
          <familyName>Doe</familyName>
          <formatted>Jane Doe</formatted>
          <givenName>Jane</givenName>
          </name>
          </person>
          </content>
          </entry>
          <entry>
          <id>urn:guid:george.doe</id>
          <content type="application/xml">
          <person xmlns="http://ns.opensocial.org/2008/opensocial">
          <id>george.doe</id>
          <name>
          <familyName>Doe</familyName>
          <formatted>George Doe</formatted>
          <givenName>George</givenName>
          </name>
          </person>
          </content>
          </entry>
          <entry>
          <id>urn:guid:maija.m</id>
          <content type="application/xml">
          <person xmlns="http://ns.opensocial.org/2008/opensocial">
          <id>maija.m</id>
          <name>
          <familyName>Meikäläinen</familyName>
          <formatted>Maija Meikäläinen</formatted>
          <givenName>Maija</givenName>
          </name>
          </person>
          </content>
          </entry>
          <osearch:startIndex>0</osearch:startIndex>
          <osearch:totalResults>4</osearch:totalResults>
          <osearch:itemsPerPage>4</osearch:itemsPerPage>
          <author>?</author>
          <link rel="rel">???</link>
          </feed>

          Show
          Henry Saputra added a comment - After: JSON: {"list":[{"name": {"givenName":"John","formatted":"John Doe","familyName":"Doe"} ,"id":"john.doe"},{"name": {"givenName":"Jane","formatted":"Jane Doe","familyName":"Doe"} ,"id":"jane.doe"},{"name": {"givenName":"George","formatted":"George Doe","familyName":"Doe"} ,"id":"george.doe"},{"name": {"givenName":"Maija","formatted":"Maija Meikäläinen","familyName":"Meikäläinen"} ,"id":"maija.m"}],"totalResults":4,"startIndex":0,"itemsPerPage":4} XML: <response> <itemsPerPage>4</itemsPerPage><startIndex>0</startIndex><totalResults>4</totalResults><filtered>false</filtered><sorted>false</sorted><updatedSince>false</updatedSince> <list> <entry><person><id>john.doe</id><name><familyName>Doe</familyName><formatted>John Doe</formatted><givenName>John</givenName></name></person></entry><entry><person><id>jane.doe</id><name><familyName>Doe</familyName><formatted>Jane Doe</formatted><givenName>Jane</givenName></name></person></entry><entry><person><id>george.doe</id><name><familyName>Doe</familyName><formatted>George Doe</formatted><givenName>George</givenName></name></person></entry><entry><person><id>maija.m</id><name><familyName>Meikäläinen</familyName><formatted>Maija Meikäläinen</formatted><givenName>Maija</givenName></name></person></entry> </list> </response> Atom: <feed xmlns="http://www.w3.org/2005/Atom" xmlns:osearch="http://a9.com/-/spec/opensearch/1.1"> <entry> <id>urn:guid:john.doe</id> <content type="application/xml"> <person xmlns="http://ns.opensocial.org/2008/opensocial"> <id>john.doe</id> <name> <familyName>Doe</familyName> <formatted>John Doe</formatted> <givenName>John</givenName> </name> </person> </content> </entry> <entry> <id>urn:guid:jane.doe</id> <content type="application/xml"> <person xmlns="http://ns.opensocial.org/2008/opensocial"> <id>jane.doe</id> <name> <familyName>Doe</familyName> <formatted>Jane Doe</formatted> <givenName>Jane</givenName> </name> </person> </content> </entry> <entry> <id>urn:guid:george.doe</id> <content type="application/xml"> <person xmlns="http://ns.opensocial.org/2008/opensocial"> <id>george.doe</id> <name> <familyName>Doe</familyName> <formatted>George Doe</formatted> <givenName>George</givenName> </name> </person> </content> </entry> <entry> <id>urn:guid:maija.m</id> <content type="application/xml"> <person xmlns="http://ns.opensocial.org/2008/opensocial"> <id>maija.m</id> <name> <familyName>Meikäläinen</familyName> <formatted>Maija Meikäläinen</formatted> <givenName>Maija</givenName> </name> </person> </content> </entry> <osearch:startIndex>0</osearch:startIndex> <osearch:totalResults>4</osearch:totalResults> <osearch:itemsPerPage>4</osearch:itemsPerPage> <author>?</author> <link rel="rel">???</link> </feed>
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/4760/
          -----------------------------------------------------------

          Review request for shindig.

          Summary
          -------

          Fix the REST endpoints to follow the latest OpenSocial specs to wrap collection with "list" element.

          This addresses bug SHINDIG-1677.
          https://issues.apache.org/jira/browse/SHINDIG-1677

          Diffs


          trunk/java/common/src/main/java/org/apache/shindig/common/util/FutureUtil.java 1326759
          trunk/java/common/src/main/java/org/apache/shindig/protocol/JsonRpcServlet.java 1326759
          trunk/java/common/src/main/java/org/apache/shindig/protocol/RestfulCollection.java 1326759
          trunk/java/common/src/main/java/org/apache/shindig/protocol/conversion/xstream/RestfullCollectionConverter.java 1326759
          trunk/java/common/src/test/java/org/apache/shindig/protocol/RestfulCollectionTest.java 1326759
          trunk/java/social-api/src/main/java/org/apache/shindig/social/core/util/atom/AtomFeed.java 1326759
          trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulJsonActivityTest.java 1326759
          trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulJsonPeopleTest.java 1326759
          trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulXmlActivityTest.java 1326759
          trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulXmlPeopleTest.java 1326759
          trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonDelete.json 1326759
          trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json 1326759
          trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonIds.json 1326759
          trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryXmlIds.xml 1326759
          trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1326759
          trunk/java/social-api/src/test/resources/org/apache/shindig/social/opensocial/util/opensocial.xsd 1326759

          Diff: https://reviews.apache.org/r/4760/diff

          Testing
          -------

          Fixed unit tests for collection and passed the unit tests for single element.

          Thanks,

          Henry

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4760/ ----------------------------------------------------------- Review request for shindig. Summary ------- Fix the REST endpoints to follow the latest OpenSocial specs to wrap collection with "list" element. This addresses bug SHINDIG-1677 . https://issues.apache.org/jira/browse/SHINDIG-1677 Diffs trunk/java/common/src/main/java/org/apache/shindig/common/util/FutureUtil.java 1326759 trunk/java/common/src/main/java/org/apache/shindig/protocol/JsonRpcServlet.java 1326759 trunk/java/common/src/main/java/org/apache/shindig/protocol/RestfulCollection.java 1326759 trunk/java/common/src/main/java/org/apache/shindig/protocol/conversion/xstream/RestfullCollectionConverter.java 1326759 trunk/java/common/src/test/java/org/apache/shindig/protocol/RestfulCollectionTest.java 1326759 trunk/java/social-api/src/main/java/org/apache/shindig/social/core/util/atom/AtomFeed.java 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulJsonActivityTest.java 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulJsonPeopleTest.java 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulXmlActivityTest.java 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulXmlPeopleTest.java 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonDelete.json 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonIds.json 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryXmlIds.xml 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1326759 trunk/java/social-api/src/test/resources/org/apache/shindig/social/opensocial/util/opensocial.xsd 1326759 Diff: https://reviews.apache.org/r/4760/diff Testing ------- Fixed unit tests for collection and passed the unit tests for single element. Thanks, Henry
          Hide
          Henry Saputra added a comment -
          Show
          Henry Saputra added a comment - CR: https://reviews.apache.org/r/4760/
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/4760/#review6996
          -----------------------------------------------------------

          trunk/java/common/src/main/java/org/apache/shindig/protocol/RestfulCollection.java
          <https://reviews.apache.org/r/4760/#comment15546>

          Need to change the getter and setter bc the JSON converter uses reflection to get the entries list

          • Henry

          On 2012-04-17 23:17:54, Henry Saputra wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/4760/

          -----------------------------------------------------------

          (Updated 2012-04-17 23:17:54)

          Review request for shindig.

          Summary

          -------

          Fix the REST endpoints to follow the latest OpenSocial specs to wrap collection with "list" element.

          This addresses bug SHINDIG-1677.

          https://issues.apache.org/jira/browse/SHINDIG-1677

          Diffs

          -----

          trunk/java/common/src/main/java/org/apache/shindig/common/util/FutureUtil.java 1326759

          trunk/java/common/src/main/java/org/apache/shindig/protocol/JsonRpcServlet.java 1326759

          trunk/java/common/src/main/java/org/apache/shindig/protocol/RestfulCollection.java 1326759

          trunk/java/common/src/main/java/org/apache/shindig/protocol/conversion/xstream/RestfullCollectionConverter.java 1326759

          trunk/java/common/src/test/java/org/apache/shindig/protocol/RestfulCollectionTest.java 1326759

          trunk/java/social-api/src/main/java/org/apache/shindig/social/core/util/atom/AtomFeed.java 1326759

          trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulJsonActivityTest.java 1326759

          trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulJsonPeopleTest.java 1326759

          trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulXmlActivityTest.java 1326759

          trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulXmlPeopleTest.java 1326759

          trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonDelete.json 1326759

          trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json 1326759

          trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonIds.json 1326759

          trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryXmlIds.xml 1326759

          trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1326759

          trunk/java/social-api/src/test/resources/org/apache/shindig/social/opensocial/util/opensocial.xsd 1326759

          Diff: https://reviews.apache.org/r/4760/diff

          Testing

          -------

          Fixed unit tests for collection and passed the unit tests for single element.

          Thanks,

          Henry

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4760/#review6996 ----------------------------------------------------------- trunk/java/common/src/main/java/org/apache/shindig/protocol/RestfulCollection.java < https://reviews.apache.org/r/4760/#comment15546 > Need to change the getter and setter bc the JSON converter uses reflection to get the entries list Henry On 2012-04-17 23:17:54, Henry Saputra wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4760/ ----------------------------------------------------------- (Updated 2012-04-17 23:17:54) Review request for shindig. Summary ------- Fix the REST endpoints to follow the latest OpenSocial specs to wrap collection with "list" element. This addresses bug SHINDIG-1677 . https://issues.apache.org/jira/browse/SHINDIG-1677 Diffs ----- trunk/java/common/src/main/java/org/apache/shindig/common/util/FutureUtil.java 1326759 trunk/java/common/src/main/java/org/apache/shindig/protocol/JsonRpcServlet.java 1326759 trunk/java/common/src/main/java/org/apache/shindig/protocol/RestfulCollection.java 1326759 trunk/java/common/src/main/java/org/apache/shindig/protocol/conversion/xstream/RestfullCollectionConverter.java 1326759 trunk/java/common/src/test/java/org/apache/shindig/protocol/RestfulCollectionTest.java 1326759 trunk/java/social-api/src/main/java/org/apache/shindig/social/core/util/atom/AtomFeed.java 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulJsonActivityTest.java 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulJsonPeopleTest.java 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulXmlActivityTest.java 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulXmlPeopleTest.java 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonDelete.json 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonIds.json 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryXmlIds.xml 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1326759 trunk/java/social-api/src/test/resources/org/apache/shindig/social/opensocial/util/opensocial.xsd 1326759 Diff: https://reviews.apache.org/r/4760/diff Testing ------- Fixed unit tests for collection and passed the unit tests for single element. Thanks, Henry
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/4760/#review7012
          -----------------------------------------------------------

          Ship it!

          LGTM just one small nit

          trunk/java/common/src/test/java/org/apache/shindig/protocol/RestfulCollectionTest.java
          <https://reviews.apache.org/r/4760/#comment15587>

          small nit, change the variable name from entry to list

          • Ryan

          On 2012-04-17 23:17:54, Henry Saputra wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/4760/

          -----------------------------------------------------------

          (Updated 2012-04-17 23:17:54)

          Review request for shindig.

          Summary

          -------

          Fix the REST endpoints to follow the latest OpenSocial specs to wrap collection with "list" element.

          This addresses bug SHINDIG-1677.

          https://issues.apache.org/jira/browse/SHINDIG-1677

          Diffs

          -----

          trunk/java/common/src/main/java/org/apache/shindig/common/util/FutureUtil.java 1326759

          trunk/java/common/src/main/java/org/apache/shindig/protocol/JsonRpcServlet.java 1326759

          trunk/java/common/src/main/java/org/apache/shindig/protocol/RestfulCollection.java 1326759

          trunk/java/common/src/main/java/org/apache/shindig/protocol/conversion/xstream/RestfullCollectionConverter.java 1326759

          trunk/java/common/src/test/java/org/apache/shindig/protocol/RestfulCollectionTest.java 1326759

          trunk/java/social-api/src/main/java/org/apache/shindig/social/core/util/atom/AtomFeed.java 1326759

          trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulJsonActivityTest.java 1326759

          trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulJsonPeopleTest.java 1326759

          trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulXmlActivityTest.java 1326759

          trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulXmlPeopleTest.java 1326759

          trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonDelete.json 1326759

          trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json 1326759

          trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonIds.json 1326759

          trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryXmlIds.xml 1326759

          trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1326759

          trunk/java/social-api/src/test/resources/org/apache/shindig/social/opensocial/util/opensocial.xsd 1326759

          Diff: https://reviews.apache.org/r/4760/diff

          Testing

          -------

          Fixed unit tests for collection and passed the unit tests for single element.

          Thanks,

          Henry

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4760/#review7012 ----------------------------------------------------------- Ship it! LGTM just one small nit trunk/java/common/src/test/java/org/apache/shindig/protocol/RestfulCollectionTest.java < https://reviews.apache.org/r/4760/#comment15587 > small nit, change the variable name from entry to list Ryan On 2012-04-17 23:17:54, Henry Saputra wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4760/ ----------------------------------------------------------- (Updated 2012-04-17 23:17:54) Review request for shindig. Summary ------- Fix the REST endpoints to follow the latest OpenSocial specs to wrap collection with "list" element. This addresses bug SHINDIG-1677 . https://issues.apache.org/jira/browse/SHINDIG-1677 Diffs ----- trunk/java/common/src/main/java/org/apache/shindig/common/util/FutureUtil.java 1326759 trunk/java/common/src/main/java/org/apache/shindig/protocol/JsonRpcServlet.java 1326759 trunk/java/common/src/main/java/org/apache/shindig/protocol/RestfulCollection.java 1326759 trunk/java/common/src/main/java/org/apache/shindig/protocol/conversion/xstream/RestfullCollectionConverter.java 1326759 trunk/java/common/src/test/java/org/apache/shindig/protocol/RestfulCollectionTest.java 1326759 trunk/java/social-api/src/main/java/org/apache/shindig/social/core/util/atom/AtomFeed.java 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulJsonActivityTest.java 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulJsonPeopleTest.java 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulXmlActivityTest.java 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulXmlPeopleTest.java 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonDelete.json 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonIds.json 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryXmlIds.xml 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1326759 trunk/java/social-api/src/test/resources/org/apache/shindig/social/opensocial/util/opensocial.xsd 1326759 Diff: https://reviews.apache.org/r/4760/diff Testing ------- Fixed unit tests for collection and passed the unit tests for single element. Thanks, Henry
          Hide
          Henry Saputra added a comment -

          Committed revision 1327756

          Show
          Henry Saputra added a comment - Committed revision 1327756
          Hide
          jiraposter@reviews.apache.org added a comment -

          On 2012-04-19 00:31:10, Ryan Baxter wrote:

          > trunk/java/common/src/test/java/org/apache/shindig/protocol/RestfulCollectionTest.java, line 37

          > <https://reviews.apache.org/r/4760/diff/1/?file=102405#file102405line37>

          >

          > small nit, change the variable name from entry to list

          Thanks. Revised and Committed as revision 1327756

          • Henry

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/4760/#review7012
          -----------------------------------------------------------

          On 2012-04-17 23:17:54, Henry Saputra wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/4760/

          -----------------------------------------------------------

          (Updated 2012-04-17 23:17:54)

          Review request for shindig.

          Summary

          -------

          Fix the REST endpoints to follow the latest OpenSocial specs to wrap collection with "list" element.

          This addresses bug SHINDIG-1677.

          https://issues.apache.org/jira/browse/SHINDIG-1677

          Diffs

          -----

          trunk/java/common/src/main/java/org/apache/shindig/common/util/FutureUtil.java 1326759

          trunk/java/common/src/main/java/org/apache/shindig/protocol/JsonRpcServlet.java 1326759

          trunk/java/common/src/main/java/org/apache/shindig/protocol/RestfulCollection.java 1326759

          trunk/java/common/src/main/java/org/apache/shindig/protocol/conversion/xstream/RestfullCollectionConverter.java 1326759

          trunk/java/common/src/test/java/org/apache/shindig/protocol/RestfulCollectionTest.java 1326759

          trunk/java/social-api/src/main/java/org/apache/shindig/social/core/util/atom/AtomFeed.java 1326759

          trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulJsonActivityTest.java 1326759

          trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulJsonPeopleTest.java 1326759

          trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulXmlActivityTest.java 1326759

          trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulXmlPeopleTest.java 1326759

          trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonDelete.json 1326759

          trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json 1326759

          trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonIds.json 1326759

          trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryXmlIds.xml 1326759

          trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1326759

          trunk/java/social-api/src/test/resources/org/apache/shindig/social/opensocial/util/opensocial.xsd 1326759

          Diff: https://reviews.apache.org/r/4760/diff

          Testing

          -------

          Fixed unit tests for collection and passed the unit tests for single element.

          Thanks,

          Henry

          Show
          jiraposter@reviews.apache.org added a comment - On 2012-04-19 00:31:10, Ryan Baxter wrote: > trunk/java/common/src/test/java/org/apache/shindig/protocol/RestfulCollectionTest.java, line 37 > < https://reviews.apache.org/r/4760/diff/1/?file=102405#file102405line37 > > > small nit, change the variable name from entry to list Thanks. Revised and Committed as revision 1327756 Henry ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4760/#review7012 ----------------------------------------------------------- On 2012-04-17 23:17:54, Henry Saputra wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4760/ ----------------------------------------------------------- (Updated 2012-04-17 23:17:54) Review request for shindig. Summary ------- Fix the REST endpoints to follow the latest OpenSocial specs to wrap collection with "list" element. This addresses bug SHINDIG-1677 . https://issues.apache.org/jira/browse/SHINDIG-1677 Diffs ----- trunk/java/common/src/main/java/org/apache/shindig/common/util/FutureUtil.java 1326759 trunk/java/common/src/main/java/org/apache/shindig/protocol/JsonRpcServlet.java 1326759 trunk/java/common/src/main/java/org/apache/shindig/protocol/RestfulCollection.java 1326759 trunk/java/common/src/main/java/org/apache/shindig/protocol/conversion/xstream/RestfullCollectionConverter.java 1326759 trunk/java/common/src/test/java/org/apache/shindig/protocol/RestfulCollectionTest.java 1326759 trunk/java/social-api/src/main/java/org/apache/shindig/social/core/util/atom/AtomFeed.java 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulJsonActivityTest.java 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulJsonPeopleTest.java 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulXmlActivityTest.java 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulXmlPeopleTest.java 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonDelete.json 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonIds.json 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryXmlIds.xml 1326759 trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1326759 trunk/java/social-api/src/test/resources/org/apache/shindig/social/opensocial/util/opensocial.xsd 1326759 Diff: https://reviews.apache.org/r/4760/diff Testing ------- Fixed unit tests for collection and passed the unit tests for single element. Thanks, Henry

            People

            • Assignee:
              Henry Saputra
              Reporter:
              Henry Saputra
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development