[SHINDIG-1657] Wrap some web.xml init parameters in CDATA section

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.5.0-beta1
• Fix Version/s: 2.5.0-beta1
• Labels: patch
• Assignee: Unassigned
• Reporter: Auke van Leeuwen
• Created: 08/Nov/11 14:22
• Updated: 29/Mar/12 20:58
• Resolved: 14/Nov/11 17:16

Description

In the web.xml of the shindig-server project there are some init parameters that are supposed to be in a kind of 'properties file' format:

            <param-value>
                # The ShiroFilter configuration is very powerful and flexible, while still remaining succinct.
                # Please read the comprehensive example, with full comments and explanations, in the JavaDoc:
                #
                # http://www.jsecurity.org/api/org/jsecurity/web/servlet/JSecurityFilter.html
                [main]
                shindigSampleRealm = org.apache.shindig.sample.shiro.SampleShiroRealm
                securityManager.realm = $shindigSampleRealm
                authc.loginUrl = /login.jsp

                [urls]
                # The /login.jsp is not restricted to authenticated users (otherwise no one could log in!), but
                # the 'authc' filter must still be specified for it so it can process that url's
                # login submissions. It is 'smart' enough to allow those requests through as specified by the
                # shiro.loginUrl above.
                /login.jsp = authc

                /oauth/authorize/** = authc
                /oauth2/authorize/** = authc
            </param-value>

I have a (Liferay) server that - upon deployment - processes the web.xml and injects other elements in it. Once it reads and writes the elements, they end up on a single line since in XML the whitespace is compressed. I think the properties just need to be enclosed in a CDATA block.