Uploaded image for project: 'Shindig'
  1. Shindig
  2. SHINDIG-1494

ProxyServlet special case for Flash files is not always effective

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.0.2, 2.5.0-beta1
    • 2.5.0-beta1
    • None
    • None

    Description

      The ProxyServlet.setResponseContentHeaders() method has special logic that attempts to avoid adding a "Content-Disposition" header when the content type is "application/x-shockwave-flash". This is because adding this header causes problems with version 10 of the Flash plugin (flash apps fail to load).

      Unfortunately, though, the check is a case-insensitive exact match against "application/x-shockwave-flash", which fails to match correctly when the incoming content type is "application/x-shockwave-flash;charset=utf-8" (which it will be because the charset parameter is added elsewhere).

      Patches to perform a correct test are attached for both Shindig trunk and the 2.0.x branches.

      Attachments

        1. ProxyHandlerTrunk.patch
          2 kB
          Mark Weitzel
        2. ProxyHandler-2.0.x.patch
          2 kB
          Mark Weitzel

        Activity

          People

            Unassigned Unassigned
            weitzelm Mark Weitzel
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: