Uploaded image for project: 'Shindig'
  1. Shindig
  2. SHINDIG-1411

CSS rewriter doesnt take container into account when rewriting embedded URL's

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-RC2
    • Fix Version/s: 2.0.0
    • Component/s: Java
    • Labels:
      None

      Description

      I ran into a container configuration related issue while testing out RC2, which is that the CSS rewriter doesn't seem to be taking the container into account when rewriting embedded URL's – it always uses the default container configuration which ends up giving me invalid proxy URL's in my rewritten CSS. This appears to be due to the fact that the CssResponseRewriter uses the DomWalker.makeGadget method to create a Gadget instance to pass to the ProxyUriManager.ProxyUri constructor, but the GadgetContext inside that Gadget instance doesnt have the container set, which makes code that runs later in the ProxyUriManager to generate the proxy URL use the default container configuration instead of my custom container configuration.

        Attachments

        1. CSSRewriterPatch.patch
          15 kB
          Jesse Ciancetta

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              jcian Jesse Ciancetta
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: