Uploaded image for project: 'Shindig'
  1. Shindig
  2. SHINDIG-1399

Improved extensibility for PHP Shindig

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0-RC2
    • Component/s: PHP
    • Labels:
      None

      Description

      This patch improves the extensibility with container specific implementation in PHP shindig by:

      • making several classes better overrideable by making former private methods and members protected
      • using dependency injection for Gadget, GadgetContext, GadgetFactory, GadgetSpecParser, GadgetSpec, Substitutions and ProxyHandler
      • providing the current GadgetContext in GadgetSpecParser

      Additionally TemplateLibraries can now be loaded with relative path as well (like the messagebundles). So that we don't have copied logic here, I moved the code to determine the absolute url out of the relative one out of the GadgetFactory into RemoteContentRequest class.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              bhofmann Bastian Hofmann
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: