Uploaded image for project: 'Shindig'
  1. Shindig
  2. SHINDIG-1354

org.apache.shindig.gadgets.parse.DefaultHtmlSerializer#serialize drops trailing comments

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Trivial
    • Resolution: Fixed
    • None
    • 2.0.0-RC2
    • Java
    • None

    Description

      Summary says it all.

      Suggested diffs:

      Index: java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/DefaultHtmlSerializer.java
      ===================================================================
      — java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/DefaultHtmlSerializer.java (revision 951057)
      +++ java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/DefaultHtmlSerializer.java (working copy)
      @@ -66,7 +66,10 @@
      break;
      }
      case Node.DOCUMENT_NODE: {

      • serialize(((Document)n).getDocumentElement(), output, xmlMode);
        + NodeList children = ((Document)n).getChildNodes();
        + for (int i = 0; i < children.getLength(); i++) { + serialize(children.item(i), output, xmlMode); + }

        break;
        }
        case Node.ELEMENT_NODE: {

      Diffs will be submitted for code review.

      Attachments

        Activity

          People

            Unassigned Unassigned
            jluehe Jan Luehe
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: