[SHALE-405] Incorrect logic in MockApplication12.addELResolver(ELResolver resolver)

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.1.0-SNAPSHOT
• Fix Version/s: 1.0.5
• Component/s: Test
• Environment: Not environment specific
• Flags: Important
• Assignee: Rahul Akolkar
• Reporter: Doug Chasman
• Created: 04/Feb/07 16:14
• Updated: 18/Apr/09 16:08
• Resolved: 05/Feb/07 21:12

Description

Current implementation will never allow addition of el resolvers regardless of the point in the app lifecycle:

/**

{@inheritDoc} */
public void addELResolver(ELResolver resolver) {

// Simulate the restriction that you cannot add resolvers after
// the first request has been processed.
if (resolver != null) { throw new IllegalStateException("Cannot add resolvers now"); }

resolvers.add(resolver);

}

should read:

/** {@inheritDoc}

*/
public void addELResolver(ELResolver resolver) {

// Simulate the restriction that you cannot add resolvers after
// the first request has been processed.
if (this.resolver != null)

{ throw new IllegalStateException("Cannot add resolvers now"); }

resolvers.add(resolver);

}