Uploaded image for project: 'Shale'
  1. Shale
  2. SHALE-397

Add DialogContextHelper with static accessors to eliminate need to manipulate scoped attributes directly

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.0.4, 1.1.0-SNAPSHOT
    • 1.1.0-SNAPSHOT
    • None
    • None

    Description

      The current implementation of the dialog machinery in Shale occasionally requires the application to directly access scoped attributes via a symbolic constant string. Examples include accessing the current DialogContextManager instance, creating it if necessary. This is unnecessarily brittle, and restricts possible future improvements in the actual functionality.

      To replace this, create a DialogContextHelper class with static convenience methods that perform the same logic currently required of the application in these use cases, but abstracted away to simplify application logic and insulate it from future changes in the internal implementation.

      Attachments

        Activity

          People

            craigmcc Craig R. McClanahan
            craigmcc Craig R. McClanahan
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: