[SENTRY-893] Synchronize calls in SentryClient and create sentry client once per request in SimpleDBProvider

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4.0
• Fix Version/s: 1.7.0
• Assignee: Sravya Tirukkovalur
• Reporter: Sravya Tirukkovalur
• Created: 21/Sep/15 21:06
• Updated: 24/Nov/15 22:45
• Resolved: 09/Oct/15 23:14

Description

We periodically see "out of sequence response" error from thrift layer as thrift itself is not thread safe and lets mutliple clients read each other's sockets. See http://mail-archives.apache.org/mod_mbox/thrift-user/201208.mbox/[e-mail]%3E

Caused by: sentry.org.apache.thrift.TApplicationException: list_sentry_privileges_for_provider failed: out of sequence response at sentry.org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:76)

Would be best to synchronize the calls on client side to avoid this situation. We might follow up to allow locking just the transport.

Issue Links

• contains: SENTRY-835 Drop table leaves a connection open when using metastorelistener
• is duplicated by: SENTRY-677 Make the Sentry DB provider RPC methods synchronized