[SENTRY-699] Memory leak when running Sentry w/ HiveServer2

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.0
• Fix Version/s: 1.6.0
• Assignee: Prasad Suresh Mujumdar
• Reporter: Lenni Kuff
• Created: 15/Apr/15 17:47
• Updated: 28/Apr/15 16:32
• Resolved: 28/Apr/15 16:32

Description

Each time a query executes we create a new instance of HiveAuthzConf which in turn creates a ResourceAuthorizationProvider. Within ResourceAuthorizationProvider there is a thread local variable: "ThreadLocal<List<String>> lastFailedPrivileges" which is not getting garbage collected since the parent thread is still alive. Over time, this leads to a memory leak in HS2. We need to be sure that any ThreadLocal state is cleaned up when we are done using it (or consider avoiding the use of ThreadLocal if possible).