[SENTRY-563] The interface listPrivilegesByRoleName may throw thrift exception if Authorizable is empty

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.5.0
• Assignee: Xiaomeng Huang
• Reporter: Xiaomeng Huang
• Created: 03/Dec/14 06:25
• Updated: 18/Mar/15 05:13
• Resolved: 29/Jan/15 07:42

Description

public Set<TSentryPrivilege> listPrivilegesByRoleName(String requestorUserName,
      String roleName, List<? extends Authorizable> authorizable)
  throws SentryUserException {
    TListSentryPrivilegesRequest request = new TListSentryPrivilegesRequest();
    request.setProtocol_version(ThriftConstants.TSENTRY_SERVICE_VERSION_CURRENT);
    request.setRequestorUserName(requestorUserName);
    request.setRoleName(roleName);
    if (authorizable != null) {   ==> we should add check empty of authorizable here.
      TSentryAuthorizable tSentryAuthorizable = setupSentryAuthorizable(authorizable);
      request.setAuthorizableHierarchy(tSentryAuthorizable);
    }
   ...

Please see my test cases in this patch, before this patch, it will throw exception.
Sentry client interface should be robustness, it also blocks SHOW GRANT DDL of V2 feature.

Issue Links

• blocks: SENTRY-498 Sentry integration with Hive authorization framework V2
• is depended upon by: SENTRY-514 Enable e2e tests for authorization V2