[SENTRY-2043] Understand the reason of the KeyValue class design

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Component/s: Sentry
• Assignee: Sergio Peña
• Reporter: Sergio Peña
• Created: 13/Nov/17 17:18
• Updated: 14/Nov/17 17:16
• Resolved: 14/Nov/17 17:16

Description

The KeyValue class is used to split a key-value string that Sentry uses to understand permissions. The community has some concern around this class because a string parsing is done on the constructor and the equals() method was case-insensitive before 1.7, then case-sensitive in 1.8 (caused hbase-indexer test failures), then case-insensitive on 2.0.

We should investigate if we can replace the KeyValue by a different more common class, such as apache commons Pair, and if we can find the reason about case sensitivity with other models.

This is a task jira, and if we find improvements on the class or the code, then we should create another JIRA to do that.

Issue Links

• relates to: SENTRY-2039 KeyValue is case sensitive and it causes incompatibility issues with external components
• relates to: SENTRY-999 Refactor the sentry to integrate with external components quickly