Uploaded image for project: 'Sentry (Retired)'
  1. Sentry (Retired)
  2. SENTRY-2021

MR session ACLs in Hive binding does not handle all types of ACLs

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.0
    • Fix Version/s: 2.0.0
    • Component/s: Hive Binding
    • Labels:
      None

      Description

      When an ACL is configured to only have groups and no users the ACL starts with a space.
      The ACL that is read from the config currently gets trimmed which removes the space and thus converts the groups into users.
      We should not trim the space from the ACL and merge the user name correctly:

      • if the ACL starts with a space just add the username to the start
      • if the ACL does not start with a space add the username separated by a comma

      The change was introduced by SENTRY-158.

        Attachments

        1. SENTRY-2021.001.patch
          1 kB
          wilfreds#1
        2. SENTRY-2021.002.patch
          2 kB
          wilfreds#1
        3. SENTRY-2021.003.patch
          2 kB
          wilfreds#1
        4. SENTRY-2021.004.patch
          2 kB
          wilfreds#1
        5. SENTRY-2021.005.patch
          5 kB
          wilfreds#1

          Activity

            People

            • Assignee:
              wilfreds Wilfred Spiegelenburg
              Reporter:
              wilfreds Wilfred Spiegelenburg
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: