Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12877213/SENTRY-1844.001.patch against master.

Overall: +1 all checks pass

SUCCESS: all tests passed

Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3035/console

This message is automatically generated.

Dapeng Sun, Na Li Please review this patch. Thanks.

Hi Donghui Xu, the fix looks good, please add a Unit Test for this issue. Thanks!

Donghui Xu, for your reference:
https://github.com/apache/sentry/blob/master/sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryWebServerWithKerberos.java
https://github.com/apache/sentry/blob/master/sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryWebServerWithoutSecurity.java

Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12877516/SENTRY-1844.002.patch against master.

Overall: -1 due to an error

ERROR: failed to build with patch (exit code 1)

Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3050/console

This message is automatically generated.

Dapeng Sun Thank you for your reference. I have added test case for the scene while SENTRY_WEB_SECURITY_TYPE is none.

Thank Donghui Xu, the patch may miss some imports. Could you fix them?

Dapeng Sun OK. I have fixed them.

Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12877521/SENTRY-1844.003.patch against master.

Overall: -1 due to 2 errors

ERROR: mvn test exited 1
ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryWebServiceForAuthTypeNone

Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3051/console

This message is automatically generated.

Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12877568/SENTRY-1844.004.patch against master.

Overall: -1 due to 2 errors

ERROR: mvn test exited 1
ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryWebServiceForAuthTypeNone

Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3053/console

This message is automatically generated.

Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12877712/SENTRY-1844.005.patch against master.

Overall: -1 due to 2 errors

ERROR: mvn test exited 1
ERROR: Failed: org.apache.sentry.tests.e2e.dbprovider.TestDbConnections

Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3060/console

This message is automatically generated.

Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12877712/SENTRY-1844.005.patch against master.

Overall: +1 all checks pass

SUCCESS: all tests passed

Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3061/console

This message is automatically generated.

+1

Hi Dapeng Sun,I want to know whether the patch has been committed. There seems to be no other person to review this patch.

Committed to master. Thank Donghui Xu for the contribution.

commit b6239b2bad38399d356f3dccb703e4d80250bdb2
Author: Donghui Xu <xu.donghui@zte.com.cn>
Date: Mon Jul 24 15:21:12 2017 +0800

SENTRY-1844 - When setting web authentication type to none, sentry fails to start

• Reviewed by: Dapeng Sun.