Uploaded image for project: 'Sentry'
  1. Sentry
  2. SENTRY-1844

When setting web authentication type to none, sentry fails to start

        Details

        • Type: Bug
        • Status: Patch Available
        • Priority: Major
        • Resolution: Unresolved
        • Affects Version/s: None
        • Fix Version/s: None
        • Component/s: Sentry
        • Labels:
          None

          Description

          When setting web authentication type to none, sentry fails to start. Because sentry can not recognize none value.

          1. Text File
            SENTRY-1844.001.patch
            1 kB
            Donghui Xu
          2. Text File
            SENTRY-1844.002.patch
            4 kB
            Donghui Xu
          3. Text File
            SENTRY-1844.003.patch
            4 kB
            Donghui Xu
          4. Text File
            SENTRY-1844.004.patch
            5 kB
            Donghui Xu
          5. Text File
            SENTRY-1844.005.patch
            4 kB
            Donghui Xu

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            hadoopqa Hadoop QA added a comment -

            Here are the results of testing the latest attachment
            https://issues.apache.org/jira/secure/attachment/12877213/SENTRY-1844.001.patch against master.

            Overall: +1 all checks pass

            SUCCESS: all tests passed

            Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3035/console

            This message is automatically generated.

            Show
            hadoopqa Hadoop QA added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12877213/SENTRY-1844.001.patch against master. Overall: +1 all checks pass SUCCESS: all tests passed Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3035/console This message is automatically generated.
            Hide
            Permalink
            davidxdh Donghui Xu added a comment - - edited

            Dapeng Sun, Na Li Please review this patch. Thanks.

            Show
            davidxdh Donghui Xu added a comment - - edited Dapeng Sun , Na Li Please review this patch. Thanks.
            Hide
            Permalink
            dapengsun Dapeng Sun added a comment -

            Hi Donghui Xu, the fix looks good, please add a Unit Test for this issue. Thanks!

            Show
            dapengsun Dapeng Sun added a comment - Hi Donghui Xu , the fix looks good, please add a Unit Test for this issue. Thanks!
            Hide
            Permalink
            dapengsun Dapeng Sun added a comment -

            Donghui Xu, for your reference:
            https://github.com/apache/sentry/blob/master/sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryWebServerWithKerberos.java
            https://github.com/apache/sentry/blob/master/sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryWebServerWithoutSecurity.java

            Show
            dapengsun Dapeng Sun added a comment - Donghui Xu , for your reference: https://github.com/apache/sentry/blob/master/sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryWebServerWithKerberos.java https://github.com/apache/sentry/blob/master/sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryWebServerWithoutSecurity.java
            Hide
            Permalink
            hadoopqa Hadoop QA added a comment -

            Here are the results of testing the latest attachment
            https://issues.apache.org/jira/secure/attachment/12877516/SENTRY-1844.002.patch against master.

            Overall: -1 due to an error

            ERROR: failed to build with patch (exit code 1)

            Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3050/console

            This message is automatically generated.

            Show
            hadoopqa Hadoop QA added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12877516/SENTRY-1844.002.patch against master. Overall: -1 due to an error ERROR: failed to build with patch (exit code 1) Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3050/console This message is automatically generated.
            Hide
            Permalink
            davidxdh Donghui Xu added a comment -

            Dapeng Sun Thank you for your reference. I have added test case for the scene while SENTRY_WEB_SECURITY_TYPE is none.

            Show
            davidxdh Donghui Xu added a comment - Dapeng Sun Thank you for your reference. I have added test case for the scene while SENTRY_WEB_SECURITY_TYPE is none.
            Hide
            Permalink
            dapengsun Dapeng Sun added a comment -

            Thank Donghui Xu, the patch may miss some imports. Could you fix them?

            Show
            dapengsun Dapeng Sun added a comment - Thank Donghui Xu , the patch may miss some imports. Could you fix them?
            Hide
            Permalink
            davidxdh Donghui Xu added a comment -

            Dapeng Sun OK. I have fixed them.

            Show
            davidxdh Donghui Xu added a comment - Dapeng Sun OK. I have fixed them.
            Hide
            Permalink
            hadoopqa Hadoop QA added a comment -

            Here are the results of testing the latest attachment
            https://issues.apache.org/jira/secure/attachment/12877521/SENTRY-1844.003.patch against master.

            Overall: -1 due to 2 errors

            ERROR: mvn test exited 1
            ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryWebServiceForAuthTypeNone

            Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3051/console

            This message is automatically generated.

            Show
            hadoopqa Hadoop QA added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12877521/SENTRY-1844.003.patch against master. Overall: -1 due to 2 errors ERROR: mvn test exited 1 ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryWebServiceForAuthTypeNone Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3051/console This message is automatically generated.
            Hide
            Permalink
            hadoopqa Hadoop QA added a comment -

            Here are the results of testing the latest attachment
            https://issues.apache.org/jira/secure/attachment/12877568/SENTRY-1844.004.patch against master.

            Overall: -1 due to 2 errors

            ERROR: mvn test exited 1
            ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryWebServiceForAuthTypeNone

            Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3053/console

            This message is automatically generated.

            Show
            hadoopqa Hadoop QA added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12877568/SENTRY-1844.004.patch against master. Overall: -1 due to 2 errors ERROR: mvn test exited 1 ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryWebServiceForAuthTypeNone Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3053/console This message is automatically generated.
            Hide
            Permalink
            hadoopqa Hadoop QA added a comment -

            Here are the results of testing the latest attachment
            https://issues.apache.org/jira/secure/attachment/12877712/SENTRY-1844.005.patch against master.

            Overall: -1 due to 2 errors

            ERROR: mvn test exited 1
            ERROR: Failed: org.apache.sentry.tests.e2e.dbprovider.TestDbConnections

            Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3060/console

            This message is automatically generated.

            Show
            hadoopqa Hadoop QA added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12877712/SENTRY-1844.005.patch against master. Overall: -1 due to 2 errors ERROR: mvn test exited 1 ERROR: Failed: org.apache.sentry.tests.e2e.dbprovider.TestDbConnections Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3060/console This message is automatically generated.
            Hide
            Permalink
            hadoopqa Hadoop QA added a comment -

            Here are the results of testing the latest attachment
            https://issues.apache.org/jira/secure/attachment/12877712/SENTRY-1844.005.patch against master.

            Overall: +1 all checks pass

            SUCCESS: all tests passed

            Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3061/console

            This message is automatically generated.

            Show
            hadoopqa Hadoop QA added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12877712/SENTRY-1844.005.patch against master. Overall: +1 all checks pass SUCCESS: all tests passed Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3061/console This message is automatically generated.
            Hide
            Permalink
            dapengsun Dapeng Sun added a comment -

            +1

            Show
            dapengsun Dapeng Sun added a comment - +1

              People

              • Assignee:
                davidxdh Donghui Xu
                Reporter:
                davidxdh Donghui Xu
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Development