Uploaded image for project: 'Sentry'
  1. Sentry
  2. SENTRY-1844

When setting web authentication type to none, sentry fails to start

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.8.0
    • Component/s: Sentry
    • Labels:
      None

      Description

      When setting web authentication type to none, sentry fails to start. Because sentry can not recognize none value.

      1. SENTRY-1844.005.patch
        4 kB
        Donghui Xu
      2. SENTRY-1844.004.patch
        5 kB
        Donghui Xu
      3. SENTRY-1844.003.patch
        4 kB
        Donghui Xu
      4. SENTRY-1844.002.patch
        4 kB
        Donghui Xu
      5. SENTRY-1844.001.patch
        1 kB
        Donghui Xu

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -

        Here are the results of testing the latest attachment
        https://issues.apache.org/jira/secure/attachment/12877213/SENTRY-1844.001.patch against master.

        Overall: +1 all checks pass

        SUCCESS: all tests passed

        Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3035/console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12877213/SENTRY-1844.001.patch against master. Overall: +1 all checks pass SUCCESS: all tests passed Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3035/console This message is automatically generated.
        Hide
        davidxdh Donghui Xu added a comment - - edited

        Dapeng Sun, Na Li Please review this patch. Thanks.

        Show
        davidxdh Donghui Xu added a comment - - edited Dapeng Sun , Na Li Please review this patch. Thanks.
        Hide
        dapengsun Dapeng Sun added a comment -

        Hi Donghui Xu, the fix looks good, please add a Unit Test for this issue. Thanks!

        Show
        dapengsun Dapeng Sun added a comment - Hi Donghui Xu , the fix looks good, please add a Unit Test for this issue. Thanks!
        Show
        dapengsun Dapeng Sun added a comment - Donghui Xu , for your reference: https://github.com/apache/sentry/blob/master/sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryWebServerWithKerberos.java https://github.com/apache/sentry/blob/master/sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryWebServerWithoutSecurity.java
        Hide
        hadoopqa Hadoop QA added a comment -

        Here are the results of testing the latest attachment
        https://issues.apache.org/jira/secure/attachment/12877516/SENTRY-1844.002.patch against master.

        Overall: -1 due to an error

        ERROR: failed to build with patch (exit code 1)

        Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3050/console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12877516/SENTRY-1844.002.patch against master. Overall: -1 due to an error ERROR: failed to build with patch (exit code 1) Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3050/console This message is automatically generated.
        Hide
        davidxdh Donghui Xu added a comment -

        Dapeng Sun Thank you for your reference. I have added test case for the scene while SENTRY_WEB_SECURITY_TYPE is none.

        Show
        davidxdh Donghui Xu added a comment - Dapeng Sun Thank you for your reference. I have added test case for the scene while SENTRY_WEB_SECURITY_TYPE is none.
        Hide
        dapengsun Dapeng Sun added a comment -

        Thank Donghui Xu, the patch may miss some imports. Could you fix them?

        Show
        dapengsun Dapeng Sun added a comment - Thank Donghui Xu , the patch may miss some imports. Could you fix them?
        Hide
        davidxdh Donghui Xu added a comment -

        Dapeng Sun OK. I have fixed them.

        Show
        davidxdh Donghui Xu added a comment - Dapeng Sun OK. I have fixed them.
        Hide
        hadoopqa Hadoop QA added a comment -

        Here are the results of testing the latest attachment
        https://issues.apache.org/jira/secure/attachment/12877521/SENTRY-1844.003.patch against master.

        Overall: -1 due to 2 errors

        ERROR: mvn test exited 1
        ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryWebServiceForAuthTypeNone

        Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3051/console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12877521/SENTRY-1844.003.patch against master. Overall: -1 due to 2 errors ERROR: mvn test exited 1 ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryWebServiceForAuthTypeNone Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3051/console This message is automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -

        Here are the results of testing the latest attachment
        https://issues.apache.org/jira/secure/attachment/12877568/SENTRY-1844.004.patch against master.

        Overall: -1 due to 2 errors

        ERROR: mvn test exited 1
        ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryWebServiceForAuthTypeNone

        Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3053/console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12877568/SENTRY-1844.004.patch against master. Overall: -1 due to 2 errors ERROR: mvn test exited 1 ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryWebServiceForAuthTypeNone Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3053/console This message is automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -

        Here are the results of testing the latest attachment
        https://issues.apache.org/jira/secure/attachment/12877712/SENTRY-1844.005.patch against master.

        Overall: -1 due to 2 errors

        ERROR: mvn test exited 1
        ERROR: Failed: org.apache.sentry.tests.e2e.dbprovider.TestDbConnections

        Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3060/console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12877712/SENTRY-1844.005.patch against master. Overall: -1 due to 2 errors ERROR: mvn test exited 1 ERROR: Failed: org.apache.sentry.tests.e2e.dbprovider.TestDbConnections Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3060/console This message is automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -

        Here are the results of testing the latest attachment
        https://issues.apache.org/jira/secure/attachment/12877712/SENTRY-1844.005.patch against master.

        Overall: +1 all checks pass

        SUCCESS: all tests passed

        Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3061/console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12877712/SENTRY-1844.005.patch against master. Overall: +1 all checks pass SUCCESS: all tests passed Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3061/console This message is automatically generated.
        Hide
        dapengsun Dapeng Sun added a comment -

        +1

        Show
        dapengsun Dapeng Sun added a comment - +1
        Hide
        davidxdh Donghui Xu added a comment -

        Hi Dapeng Sun,I want to know whether the patch has been committed. There seems to be no other person to review this patch.

        Show
        davidxdh Donghui Xu added a comment - Hi Dapeng Sun ,I want to know whether the patch has been committed. There seems to be no other person to review this patch.
        Hide
        dapengsun Dapeng Sun added a comment -

        Committed to master. Thank Donghui Xu for the contribution.

        commit b6239b2bad38399d356f3dccb703e4d80250bdb2
        Author: Donghui Xu <xu.donghui@zte.com.cn>
        Date: Mon Jul 24 15:21:12 2017 +0800

        SENTRY-1844 - When setting web authentication type to none, sentry fails to start

        • Reviewed by: Dapeng Sun.
        Show
        dapengsun Dapeng Sun added a comment - Committed to master. Thank Donghui Xu for the contribution. commit b6239b2bad38399d356f3dccb703e4d80250bdb2 Author: Donghui Xu <xu.donghui@zte.com.cn> Date: Mon Jul 24 15:21:12 2017 +0800 SENTRY-1844 - When setting web authentication type to none, sentry fails to start Reviewed by: Dapeng Sun.

          People

          • Assignee:
            davidxdh Donghui Xu
            Reporter:
            davidxdh Donghui Xu
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development