Uploaded image for project: 'Sentry'
  1. Sentry
  2. SENTRY-872 Uber jira for HMS HA + Sentry HA redesign
  3. SENTRY-1824

SentryStore may serialize transactions that rely on unique key

    XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0
    • Fix Version/s: 2.0.0
    • Component/s: Sentry
    • Labels:

      Description

      The suggestion came from Na Li during the review for SENTRY-1821.

      We have several places where we rely on transactions to support read/modify/write semantics for incrementing IDs. This works but using DB support is rather expensive and we can user in-core serializations to help with this at least within a single node and rely on DB for multi-node synchronization.

      This isn't much of a problem for path updates since they are driven by HMSFollower which usually runs on a single leader node, but permission updates originate from clients directly and may be highly concurrent.

      We are internally serializing all permissions update anyway, so doing partial serialization on every node helps.

      The patch serializes all calls that affect permission updates.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                linaataustin Na Li
                Reporter:
                akolb Alex Kolbasov
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 72h
                  72h
                  Remaining:
                  Remaining Estimate - 72h
                  72h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified