[SENTRY-1800] Flaky testConcurrentUpdateChanges test

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.0.0
• Component/s: Sentry
• Labels: sentry-ha
• Assignee: Alex Kolbasov
• Reporter: Alex Kolbasov
• Created: 10/Jun/17 00:21
• Updated: 24/Jul/17 14:51
• Resolved: 10/Jun/17 06:49

Description

The fixed for SENTRY-1795 was supposed to guarantee that we don't have any holes in the update tables.

The ffix includes the new test TestSentryStore#testDuplicateNotification. This test passes sometimes but sometimes fails, for example:

java.lang.AssertionError: 
Expected :5000
Actual   :4863
 <Click to see difference>


	at org.junit.Assert.fail(Assert.java:93)
	at org.junit.Assert.failNotEquals(Assert.java:647)
	at org.junit.Assert.assertEquals(Assert.java:128)
	at org.junit.Assert.assertEquals(Assert.java:472)
	at org.junit.Assert.assertEquals(Assert.java:456)
	at org.apache.sentry.provider.db.service.persistent.TestSentryStore.testConcurrentUpdateChanges(TestSentryStore.java:2977)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
	at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:62)

It fails here:

    List<MSentryPermChange> changes = sentryStore.getMSentryPermChanges();
    assertEquals(numThreads * numChangesPerThread, changes.size());

meaning that some changes are missing. The question is whether they are missing with holes or we just have a shorter list?

Issue Links

• relates to: SENTRY-1580 Provide pooled client connection model with HA