[SENTRY-1783] alterSentryRoleGrantPrivilegeCore does more persistence work than required

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.8.0, 2.0.0
• Fix Version/s: 1.8.0, 2.0.0
• Component/s: sentrystore
• Assignee: Alex Kolbasov
• Reporter: Alex Kolbasov
• Created: 24/May/17 23:17
• Updated: 24/Jul/17 15:36
• Resolved: 26/May/17 06:25

Description

In the end of alterSentryRoleGrantPrivilegeCore() there is the following code:

mPrivilege.appendRole(mRole);
pm.makePersistent(mRole);
pm.makePersistent(mPrivilege);

I think the second makePersistent call isn't needed and can only cause troubles (extra potential for deadlock). When the role is made persistent, the associated privilege should be updated as well.