[SENTRY-1752] HMSFollower gets stuck once it fails to process a notification event

• Type: Sub-task
• Status: Resolved
• Priority: Critical
• Resolution: Duplicate
• Affects Version/s: 2.0.0
• Fix Version/s: 2.0.0
• Component/s: Sentry
• Labels: security
• Assignee: Na Li
• Reporter: Na Li
• Created: 05/May/17 15:35
• Updated: 25/Oct/17 18:52
• Resolved: 25/Oct/17 18:52

Description

If HMSFollower encounters an event that causes exception, it just stops processing for this run and does not continue processing the rest of notification events.

The end result is that it cannot process any more notification events, and Sentry won't get any update from meta store from then on.

for example, due to bug SENTRY-1750 "HMSFollower does not handle view update correctly", A create view event will cause exception. And the processing ends for this run. Next run, this event is still fetched from meta store, exception happens, and it stops processing again. So no events from that failed event can be processed, and no more update will be picked up be Sentry.

When there is an exception in processing a notification event, should we still update the current notification ID, so we can move on?

Issue Links

• duplicates: SENTRY-1669 HMSFollower should read current processed notification ID from database every time it runs
• duplicates: SENTRY-1659 HMSPathsDumper has useless code
• is blocked by: SENTRY-1669 HMSFollower should read current processed notification ID from database every time it runs
• is duplicated by: SENTRY-1693 HMSFollower should handle adding a view with empty path.
• links to: Review Board Link for this case