[SENTRY-1698] PathsUpdate.parsePath() calls FileSystem.getDefaultUri() way too often

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.8.0, 2.0.0
• Fix Version/s: 2.0.0
• Component/s: Sentry
• Labels: bite-sized newbie
• Assignee: Alex Kolbasov
• Reporter: Alex Kolbasov
• Created: 07/Apr/17 04:18
• Updated: 24/Jul/17 14:52
• Resolved: 26/Apr/17 18:18

Description

The PathsUpdate#parsePath() method has the following code:

      String scheme = uri.getScheme();
      if (scheme == null) {
        // Use the default URI scheme only if the path has no scheme.
        URI defaultUri = FileSystem.getDefaultUri(CONF);

The default URI never changes so there is no need to call FileSystem.getDefaultUri(CONF) for each input string which doesn't have URI. This should be done once in constructor.

Issue Links

• relates to: SENTRY-1687 FullUpdateInitializer can be more efficient