[SENTRY-1663] UpdateableAuthzPermissions has mutable static fields

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.8.0
• Fix Version/s: 1.8.0, 2.0.0
• Component/s: Sentry
• Labels: bite-sized newbie
• Assignee: Jan Hentschel
• Reporter: Alex Kolbasov
• Created: 15/Mar/17 06:30
• Updated: 02/Oct/19 17:27
• Resolved: 15/Mar/17 23:19

Description

UpdateableAuthzPermissions has the following code:

  public static final Map<String, FsAction> ACTION_MAPPING = new HashMap<String, FsAction>();
  
  static {
    ACTION_MAPPING.put("ALL", FsAction.ALL);
    ACTION_MAPPING.put("*", FsAction.ALL);
    ACTION_MAPPING.put("SELECT", FsAction.READ_EXECUTE);
    ACTION_MAPPING.put("select", FsAction.READ_EXECUTE);
    ACTION_MAPPING.put("INSERT", FsAction.WRITE_EXECUTE);
    ACTION_MAPPING.put("insert", FsAction.WRITE_EXECUTE);
  }

It should use ImmutableMap instead.

Issue Links

• links to: Link to Review Board