[SENTRY-1658] Null pointer dereference in SentryShellHive

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.8.0
• Fix Version/s: 1.8.0, 2.0.0
• Component/s: Sentry
• Labels: bite-sized newbie
• Assignee: Jan Hentschel
• Reporter: Alex Kolbasov
• Created: 15/Mar/17 06:07
• Updated: 02/Oct/19 17:27
• Resolved: 15/Mar/17 23:41

Description

In SentryShellHive.java there is the following code:

  public static void main(String[] args) throws Exception {
    SentryShellHive sentryShell = new SentryShellHive();
    try {
      sentryShell.executeShell(args);
    } catch (Exception e) {
      LOGGER.error(e.getMessage(), e);
      Throwable current =  e;
      // find the first printable message;
      while (current != null && current.getMessage() == null) {
        current = current.getCause();
      }
      // current can be null here
       System.out.println("The operation failed." +
          (current.getMessage() == null ? "" : "  Message: " + current.getMessage()));
    }
  }

Note that current can be null when we call getMessage()

Issue Links

• links to: Link to Review Board