[SENTRY-1506] Importing JDO or datanucleus properties from config is broken

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Not A Problem
• Affects Version/s: 1.7.0, 2.0.0
• Component/s: Sentry
• Assignee: Alex Kolbasov
• Reporter: Alex Kolbasov
• Created: 18/Oct/16 17:51
• Updated: 24/Jul/17 14:44
• Resolved: 18/Oct/16 23:24

Description

SentryStore.java has a piece of code that takes JDO or datanucleus properties from config file:

    public static final String SENTRY_DB_PROPERTY_PREFIX = "sentry.";
    public static final String SENTRY_JAVAX_JDO_PROPERTY_PREFIX = SENTRY_DB_PROPERTY_PREFIX + "javax.jdo";
    public static final String SENTRY_DATANUCLEUS_PROPERTY_PREFIX = SENTRY_DB_PROPERTY_PREFIX + "datanucleus";

    for (Map.Entry<String, String> entry : conf) {
      String key = entry.getKey();
      if (key.startsWith(ServerConfig.SENTRY_JAVAX_JDO_PROPERTY_PREFIX) ||
          key.startsWith(ServerConfig.SENTRY_DATANUCLEUS_PROPERTY_PREFIX)) {
        key = StringUtils.removeStart(key, ServerConfig.SENTRY_DB_PROPERTY_PREFIX);
        prop.setProperty(key, entry.getValue());
      }
    }

The intention apparently was to read properties starting from "sentry." but the code picks up properties which don't start with ".sentry".

So the code doesn't make much sense, but an important question is whether anyone depends on the existing behavior.

Issue Links

• relates to: SENTRY-872 Uber jira for HMS HA + Sentry HA redesign