Uploaded image for project: 'Sentry'
  1. Sentry
  2. SENTRY-1233

Logging improvements to SentryConfigToolSolr

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.0
    • Fix Version/s: 1.8.0
    • Component/s: Solr Plugin
    • Labels:
      None

      Description

      From working with this tool for a bit, I think the following additions would be useful:
      1) The tool warns/errors on cased role names being converted to lower case, but still prints the cased name in the log. For clarity these should also be lower cased.
      2) When not importing, we should still print a message about what we would do, i.e. a dry-run message.

      1. SENTRY-1233.patch
        5 kB
        Gregory Chanan

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -

        Here are the results of testing the latest attachment
        https://issues.apache.org/jira/secure/attachment/12802779/SENTRY-1233.patch against master.

        Overall: +1 all checks pass

        SUCCESS: all tests passed

        Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/1538/console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12802779/SENTRY-1233.patch against master. Overall: +1 all checks pass SUCCESS: all tests passed Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/1538/console This message is automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -

        Here are the results of testing the latest attachment
        https://issues.apache.org/jira/secure/attachment/12802779/SENTRY-1233.patch against master.

        Overall: -1 due to 50 errors

        ERROR: mvn test exited 1
        ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceClientPool
        ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceForHAWithKerberos
        ERROR: Failed: org.apache.sentry.provider.db.tools.TestSentryShellHive
        ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryServiceDiscovery
        ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryServiceDiscovery
        ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryServiceDiscovery
        ERROR: Failed: org.apache.sentry.provider.db.generic.tools.TestSentryConfigToolSolr
        ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceImportExport
        ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestAuthorizingDDLAuditLogWithKerberos
        ERROR: Failed: org.apache.sentry.provider.db.generic.tools.TestSentryShellSolr
        ERROR: Failed: org.apache.sentry.provider.db.tools.TestSentrySchemaTool
        ERROR: Failed: org.apache.sentry.provider.db.tools.TestSentrySchemaTool
        ERROR: Failed: org.apache.sentry.provider.db.tools.TestSentrySchemaTool
        ERROR: Failed: org.apache.sentry.provider.db.tools.TestSentrySchemaTool
        ERROR: Failed: org.apache.sentry.provider.db.tools.TestSentrySchemaTool
        ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryWebServerWithKerberos
        ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceForPoolHAWithKerberos
        ERROR: Failed: org.apache.sentry.provider.db.generic.service.persistent.TestSentryRole
        ERROR: Failed: org.apache.sentry.provider.db.generic.service.persistent.TestSentryRole
        ERROR: Failed: org.apache.sentry.provider.db.generic.service.persistent.TestSentryRole
        ERROR: Failed: org.apache.sentry.provider.db.generic.service.persistent.TestSentryRole
        ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServerForPoolHAWithoutKerberos
        ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceIntegration
        ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServerForHaWithoutKerberos
        ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryWebServerWithoutSecurity
        ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryVersion
        ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryVersion
        ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryVersion
        ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServerForPoolWithoutKerberos
        ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
        ERROR: Failed: org.apache.sentry.provider.db.generic.tools.TestSentryShellKafka
        ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryWebServerWithSSL
        ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceWithInvalidMsgSize
        ERROR: Failed: org.apache.sentry.provider.db.generic.service.thrift.TestSentryGenericServiceIntegration
        ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceForPoolWithKerberos
        ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServerWithoutKerberos
        ERROR: Failed: org.apache.sentry.provider.db.generic.service.persistent.TestPrivilegeOperatePersistence
        ERROR: Failed: org.apache.sentry.provider.db.generic.service.thrift.TestAuditLogForSentryGenericService
        ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceFailureCase
        ERROR: Failed: org.apache.sentry.provider.db.generic.service.persistent.TestDelegateSentryStore
        ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStoreImportExport
        ERROR: Failed: org.apache.sentry.provider.db.generic.service.thrift.TestSentryGenericPolicyProcessor
        ERROR: Failed: org.apache.sentry.provider.db.generic.service.thrift.TestSentryGenericPolicyProcessor
        ERROR: Failed: org.apache.sentry.provider.db.generic.service.thrift.TestSentryGenericPolicyProcessor
        ERROR: Failed: org.apache.sentry.provider.db.generic.service.thrift.TestSentryGenericPolicyProcessor
        ERROR: Failed: org.apache.sentry.provider.db.generic.service.thrift.TestSentryGenericPolicyProcessor
        ERROR: Failed: org.apache.sentry.provider.db.generic.service.thrift.TestSentryGenericPolicyProcessor
        ERROR: Failed: org.apache.sentry.provider.db.generic.service.thrift.TestSentryGenericPolicyProcessor
        ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceWithKerberos

        Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/1535/console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12802779/SENTRY-1233.patch against master. Overall: -1 due to 50 errors ERROR: mvn test exited 1 ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceClientPool ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceForHAWithKerberos ERROR: Failed: org.apache.sentry.provider.db.tools.TestSentryShellHive ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryServiceDiscovery ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryServiceDiscovery ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryServiceDiscovery ERROR: Failed: org.apache.sentry.provider.db.generic.tools.TestSentryConfigToolSolr ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceImportExport ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestAuthorizingDDLAuditLogWithKerberos ERROR: Failed: org.apache.sentry.provider.db.generic.tools.TestSentryShellSolr ERROR: Failed: org.apache.sentry.provider.db.tools.TestSentrySchemaTool ERROR: Failed: org.apache.sentry.provider.db.tools.TestSentrySchemaTool ERROR: Failed: org.apache.sentry.provider.db.tools.TestSentrySchemaTool ERROR: Failed: org.apache.sentry.provider.db.tools.TestSentrySchemaTool ERROR: Failed: org.apache.sentry.provider.db.tools.TestSentrySchemaTool ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryWebServerWithKerberos ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceForPoolHAWithKerberos ERROR: Failed: org.apache.sentry.provider.db.generic.service.persistent.TestSentryRole ERROR: Failed: org.apache.sentry.provider.db.generic.service.persistent.TestSentryRole ERROR: Failed: org.apache.sentry.provider.db.generic.service.persistent.TestSentryRole ERROR: Failed: org.apache.sentry.provider.db.generic.service.persistent.TestSentryRole ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServerForPoolHAWithoutKerberos ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceIntegration ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServerForHaWithoutKerberos ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryWebServerWithoutSecurity ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryVersion ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryVersion ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryVersion ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServerForPoolWithoutKerberos ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.generic.tools.TestSentryShellKafka ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryWebServerWithSSL ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceWithInvalidMsgSize ERROR: Failed: org.apache.sentry.provider.db.generic.service.thrift.TestSentryGenericServiceIntegration ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceForPoolWithKerberos ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServerWithoutKerberos ERROR: Failed: org.apache.sentry.provider.db.generic.service.persistent.TestPrivilegeOperatePersistence ERROR: Failed: org.apache.sentry.provider.db.generic.service.thrift.TestAuditLogForSentryGenericService ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceFailureCase ERROR: Failed: org.apache.sentry.provider.db.generic.service.persistent.TestDelegateSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStoreImportExport ERROR: Failed: org.apache.sentry.provider.db.generic.service.thrift.TestSentryGenericPolicyProcessor ERROR: Failed: org.apache.sentry.provider.db.generic.service.thrift.TestSentryGenericPolicyProcessor ERROR: Failed: org.apache.sentry.provider.db.generic.service.thrift.TestSentryGenericPolicyProcessor ERROR: Failed: org.apache.sentry.provider.db.generic.service.thrift.TestSentryGenericPolicyProcessor ERROR: Failed: org.apache.sentry.provider.db.generic.service.thrift.TestSentryGenericPolicyProcessor ERROR: Failed: org.apache.sentry.provider.db.generic.service.thrift.TestSentryGenericPolicyProcessor ERROR: Failed: org.apache.sentry.provider.db.generic.service.thrift.TestSentryGenericPolicyProcessor ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceWithKerberos Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/1535/console This message is automatically generated.

          People

          • Assignee:
            gchanan Gregory Chanan
            Reporter:
            gchanan Gregory Chanan
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development