[SEDONA-96] ST_MakeValid returning multiple geometries for polygons with holes

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.2.1
• Labels: pull-request-available
• Assignee: Martin Andersson
• Reporter: Russell W
• Created: 29/Mar/22 20:34
• Updated: 04/Sep/22 05:16
• Resolved: 04/Sep/22 05:16

Description

When pass a polygon with holes, ST_MakeValid is returning new rows for each hole. This can lead to significant incorrectness when using ST_MakeValid prior to a spatial join.

Example:

polygon = spark.createDataFrame([['{"type": "Polygon", "coordinates": [[[3, 3], [3, -3], [-3, -3], [-3, 3], [3, 3]], [[1, 1], [1, -1], [-1, -1], [-1, 1], [1, 1]]]}']], ['geometry'])
polygon = polygon.withColumn('geometry', F.expr('ST_MakeValid(ST_GeomFromGeoJSON(geometry), false)'))
polygon = polygon.withColumn('geometry', F.expr('ST_AsGeoJSON(geometry)'))
polygon

geometry
--------------------------------------------------------------------------------------------------------------------------------------------------
{"type":"Polygon","coordinates":[[[3.0,3.0],[3.0,-3.0],[-3.0,-3.0],[-3.0,3.0],[3.0,3.0]],[[1.0,1.0],[-1.0,1.0],[-1.0,-1.0],[1.0,-1.0],[1.0,1.0]]]}
{"type":"Polygon","coordinates":[[[-1.0,1.0],[1.0,1.0],[1.0,-1.0],[-1.0,-1.0],[-1.0,1.0]]]}

Input:

Output:

Issue Links

• links to: GitHub Pull Request #596