[SEDONA-284] Property values in dependency deduced POMs for shaded modules were not substituted

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.4.1
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Kristin Cowalcijk
• Created: 25/May/23 08:37
• Updated: 04/Jun/23 01:42
• Resolved: 04/Jun/23 01:42

Description

The deployed POMs of sedona-spark-shaded and flink-shaded were dependency-reduced-pom.xml generated by maven-shade-plugin. The generated POMs does not have their property values substituted. For example, the artifactId in the deployed POM of sedona-spark-shaded should be sedona-spark-shaded-3.0_2.12, while it is actually sedona-spark-shaded-${spark.compat.version}_${scala.compat.version}:

    <modelVersion>4.0.0</modelVersion>
    <parent>
        <artifactId>sedona-parent</artifactId>
        <groupId>org.apache.sedona</groupId>
        <version>1.4.0</version>
    </parent>
    <artifactId>sedona-spark-shaded-${spark.compat.version}_${scala.compat.version}</artifactId>

Fortunately, more recent versions of maven-shade-plugin can substitute property values when generating the dependency reduced POM, so we can simply upgrade the maven-shade-plugin to generate correct POMs for shaded modules. The problem went away after upgrading maven-shade-plugin from 2.1 to 3.4.1.

 SEDONA-276 tried to solve the property substitution of POMs. However, it didn't work on shaded modules. Now let's fix this problem on shaded modules as well.

Issue Links

• links to: GitHub Pull Request #841