[SEDONA-259] Adapter.toSpatialRdd in Python binding does not have valid implementation for specifying custom field names for user data

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3.1
• Fix Version/s: 1.4.0
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Kristin Cowalcijk
• Created: 10/Mar/23 12:26
• Updated: 13/Mar/23 21:34
• Resolved: 13/Mar/23 21:34

Description

We have this class method defined in sedona.utils.Adapter:

class Adapter(metaclass=MultipleMeta):
    # ...
    @classmethod
    def toSpatialRdd(cls, dataFrame: DataFrame, fieldNames: List) -> SpatialRDD:

While the method definition should be:

def toSpatialRdd(cls, dataFrame: DataFrame, geometryFieldName: str, fieldNames: List) -> SpatialRDD

Also, the current implementation of this class method refers to a non-existing function in sedona-core: jvm.PythonAdapterWrapper.toSpatialRdd.

Issue Links

• links to: GitHub Pull Request #794