[SEDONA-195] Add wkt validation and an optional srid to ST_GeomFromWKT/ST_GeomFromText

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3.0
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Martin Andersson
• Created: 16/Nov/22 08:45
• Updated: 16/Nov/22 19:28
• Resolved: 16/Nov/22 19:28

Description

Currently wkt parser errors are swallowed and null is returned. That is a bit dangerous as errors in input are hidden.

https://github.com/apache/incubator-sedona/blob/master/core/src/main/java/org/apache/sedona/core/formatMapper/FormatUtils.java#L211

Postgis:
 

# select ST_GeomFromText('not valid');
ERROR:  parse error - invalid geometry
HINT:  "no" <-- parse error at position 2 within geometry

The srid parameter is required for OGC compatibility. See postgis docs: https://postgis.net/docs/ST_GeomFromText.html
 

Issue Links

• links to: GitHub Pull Request #714