[SEDONA-179] Claim Open Geospatial Consortium compliance

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Martin Andersson
• Created: 14/Oct/22 12:01
• Updated: 06/Feb/23 18:33

Description

Sedona is mature enough now that it should be able to claim compliance with OGC sql standards. OGC has a test suite (see annex A-C in the linked document). If Sedona would implement those tests as unit tests and make them pass, Sedona should be able to claim compliance.

Adding those tests would be a good way to catch defects and regressions.

Claiming compliance would hopefully increase trust in Sedona and increase adoption.

There is a license on the first page. I looks very liberal to me. But I don't speak legal. Would this have to be cleared be Apache legal first?

https://www.ogc.org/standards/sfs

 

Update Feb 5:

 

As of on PR 755, the current SFS (TF) 1.1 compliance status of Sedona SQL is as follows. Details listed on https://github.com/apache/sedona/blob/master/sql/src/test/scala/org/apache/sedona/sql/ogc/GeometryTypesAndFunctionsTestScala.scala

 

Test	Status	Reason
T1	Not compliant	The tests do insert and select on srid and geometry_columns tables and should pass on any SQL implementation.
T2	Not compliant	The tests do insert and select on srid and geometry_columns tables and should pass on any SQL implementation.
T3	Not compliant	The tests do insert and select on srid and geometry_columns tables and should pass on any SQL implementation.
T4	Not compliant	The tests do insert and select on srid and geometry_columns tables and should pass on any SQL implementation.
T5	Not compliant	The tests do insert and select on srid and geometry_columns tables and should pass on any SQL implementation.
T6	Not compliant	ST_Dimension is not implemented in Sedona
T7	Not compliant	ST_GeometryType is SQL/MM compliant but not OGC compliant.
T8	Compliant
T9	Compliant
T10	Compliant
T11	Compliant
T12	Compliant
T13	Compliant
T14	Compliant
T15	Compliant
T16	Compliant
T17	Compliant
T18	Compliant
T19	Compliant
T20	Compliant
T21	Compliant
T22	Not compliant	ST_NumPoints is not implemented
T23	Compliant
T24	Compliant
T25	Compliant
T26	Compliant
T27	Compliant
T28	Compliant
T29	Not compliant	Interor rings are 1 indexed in OGC and PostGIS. In Sedona they are 0 indexed.
T30	Compliant
T31	Not compliant	Interor rings are 1 indexed in OGC and PostGIS. In Sedona they are 0 indexed.
T32	Compliant
T33	Compliant
T34	Compliant
T35	Compliant
T36	Compliant
T37	Compliant
T38	Compliant
T39	Compliant
T40	Compliant
T41	Compliant
T42	Compliant
T43	Compliant
T44	Compliant
T45	Not compliant	ST_Relate is not implemented in Sedona
T46	Compliant
T47	Compliant
T48	Maybe	The test answer should be "POLYGON ((56 34, 62 48, 84 48, 84 42, 56 34))". Sedona returns the same polygon but with a different starting point.
T49	Compliant
T50	Compliant
T51	Compliant
T52	Maybe	Sedona returns the same polygon but with a different starting point.

 

 

 

 

 

Issue Links

• requires: SEDONA-240 Implement ST_Relate
• requires: SEDONA-237 Implement ST_Dimension
• requires: SEDONA-238 Implement OGC GeometryType
• requires: SEDONA-239 Implement ST_NumPoints
• requires: SEDONA-241 InteriorRingN should be 1 indexed not 0 indexed
• links to: GitHub Pull Request #716
• links to: GitHub Pull Request #755