[SCXML-89] Assign.execute() doesn't remove all children of oldNode (includes fix)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.8
• Fix Version/s: 0.9

Environment

Ubuntu 7.10 (64 bit), JRE ia32-java6-sun-1.6.0.03

• Assignee: Unassigned
• Reporter: joel truher
• Created: 14/Nov/08 06:20
• Updated: 03/Dec/08 20:26
• Resolved: 14/Nov/08 23:51

Description

This code, from Assign.execute(), seems to remove the oldNode child and then ask for its next sibling, which returns null. The result is to remove the first child, but leave the other children around, so that the result of "Assign" is a concatenation of all-but-one of the old nodes, followed by the new nodes.

for (Node child = oldNode.getFirstChild();
   child != null;
   child = child.getNextSibling()) {
   oldNode.removeChild(child);
}

This (modified) code finds the next sibling before removal and produces the expected result.

for (Node child = oldNode.getFirstChild(); child != null;) {
   Node nextChild = child.getNextSibling();
   oldNode.removeChild(child);
   child = nextChild;
}

I can supply a test case if that would be helpful.