[SCM-946] Making the maven-scm-plugin fit for parallel execution (@threadSafe)

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.11.2
• Component/s: maven-plugin
• Assignee: Michael Osipov
• Reporter: Lonzak
• Created: 09/Nov/20 21:05
• Updated: 21/Nov/21 19:41
• Resolved: 20/Nov/21 19:40

Description

During our build with maven 3.5.4 we get the following warning which seem to indicate that the @threadSafe annotation has not been set for this plugin. 

[WARNING] ****************************************************************
*17:26:25 [WARNING] * Your build is requesting parallel execution, but project 
*17:26:25 [WARNING] * contains the following plugin(s) that have goals not marked 
*17:26:25 [WARNING] * as @threadSafe to support parallel building. 
*17:26:25 [WARNING] * While this /may/ work fine, please look for plugin updates 
*17:26:25 [WARNING] * and/or request plugins be made thread-safe. 
*17:26:25 [WARNING] * If reporting an issue, report it against the plugin in 
*17:26:25 [WARNING] * question, not against maven-core 
*17:26:25 [WARNING] ****************************************************************
*17:26:25 [WARNING] The following plugins are not marked @threadSafe in ourproject:
*17:26:25 [WARNING] org.apache.maven.plugins:maven-scm-plugin:1.11.2
*17:26:25 [WARNING] Enable debug to see more precisely which goals are not marked @threadSafe.
*17:26:25 [WARNING] *****************************************************************

 

We use the tag-release command.

<plugin>
 <groupId>org.apache.maven.plugins</groupId>
 <artifactId>maven-scm-plugin</artifactId>
 <executions>
  <execution>
   <id>tag-release</id>
   <phase/>
   </execution>
  </executions>
 </plugin>

 

I can not tell whether it is threadsafe but probably some project member can.

If nobody can say then set it to false to be on the safe side,

If so it should be noted in the documentation...

I created a PR to illustrate a potential fix

https://github.com/apache/maven-scm/pull/107

 

Thanks

Issue Links

• links to: GitHub Pull Request #107