Uploaded image for project: 'Maven SCM'
  1. Maven SCM
  2. SCM-909

SvnScmProviderRepository#parseUrl() does not comply with RFC 3986 and RFC 8089

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 1.10.0
    • Fix Version/s: None
    • Component/s: maven-scm-provider-svn
    • Labels:
      None

      Description

      This issue was been found on one of Jenkins slaves. Consider the following path: F:\jenkins\jenkins-slave\workspace\maven-box_maven-scm_SCM-906-3AXCXWOA5KAAL37TCEKGJUQCHVU3HMOGCVV63JP76C24C3X6DHOA@2\m\maven-scm-providers\maven-scm-providers-git\maven-scm-provider-gitexe\target. THe aforementioned class outputs:

      file:///F:/jenkins/jenkins-slave/workspace/maven-box_maven-scm_SCM-906-3AXCXWOA5KAAL37TCEKGJUQCHVU3HMOGCVV63JP76C24C3X6DHOA@2/m/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/target
      file://2/m/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/target
      

      The parse logic incorrectly assumes that the last @ is for the user info. According to RFC 8089 a file URL may contain this information, but our parser would still fail becuase it uses indexOf. It must stop searching to the first slash.

      Note: the example is from the GitExe provider, but it also applies to SvnExe.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              michael-o Michael Osipov
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: